Re: vlogin plugin and multilogin plugin

On Mon, Dec 17, 2007 at 2:55 AM, Paul Lesniewski <[email protected]> wrote:
> On Dec 17, 2007 12:55 AM, Ralf Hildebrandt <[email protected]> wrote:
>> * Ralf Hildebrandt <[email protected]>:
>> > * Paul Lesniewski <[email protected]>:
>> >
>> > > > I update the vlogin: Things go amiss.
>> > >
>> > > Ah, well you didn't mention your vlogin version(s) and that you were
>> > > also upgrading it.  Please list all relevant version information.  If
>> > > you can test and/or profile amongst different versions, this is of
>> > > course very helpful.
>> >
>> > So. Working version:
>> > Virtual Host Login (v3.8.0-1.2.7)
>> >
>> > definitely not working: Version 3.9.2
>> > But I'll have to try the other, older versions as well.
>>
>> So, I found it:
>>
>> vlogin-3.9.1-1.2.7.tar.gz works fine
>> vlogin-3.9.2-1.2.7.tar.gz introduces the problem
>
> Thanks.
>
> The major change was to add vlogin to the loading_constants hook.
> This hook gets called very early on in every page request to the SM
> source, and is where vlogin is able to override any and all SM
> configuration settings.  It appears that the configuration override
> code is heavy enough to cause the load issues you are seeing.
>
> If you are able to profile page requests between the two, that can
> also be very helpful.  If you want to play in the code, you can toy
> with hard-coding some of the if() branches in the overrideSmConfig()
> function in functions.php and/or putting some timing code therein.
> When I am able to find the time, I will try to do the same, but that
> assumes I can even reproduce the load difference in the first place,
> which I have not yet tried to do.

Ralf/others,

While I haven't yet taken to code profiling, I walked through the code
looking for obvious things that are CPU-heavy or could be short-cut.
I didn't find much except some tiny things that shouldn't make any
difference.  I'd like to hear if anyone else is seeing SM create too
much load due to the use of Vlogin, especially if those people might
be able to test version 3.9.1 as well as the newest release.

I think Ralf is using some per-user settings, and I did find a
performance fix therein, where the per-user settings file was being
read from disk on every page request, sometimes even more than once
per page request.  I changed this so that the settings are cached in
session instead.  This might help Ralf's scenario (?), and hopefully
he can test it, but on the other hand, I'm not holding my breath - the
fact that the configuration override code runs on every page request
might be the biggest hit, and there's not a lot that can be done about
that without loss of functionality.

Again, I'd like to hear other people's experience with Vlogin and
system load.  I have beta code available with the aforementioned fix
if anyone wants to test.

 - Paul

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: [email protected]
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel