Re: SquirrelMail LDAP address book feature needs implementing/tweaking

On Wed, July 2, 2008 05:30, Paul Lesniewski wrote:
> I have a question about what $dn becomes in your patch as opposed to
> what it was before.  Before your patch, there was a comma and
> $this->basedn following the "cn=VALUE".  Your patch takes it out.  Is
> this intentional or a bug?

It was intentional but I was hesitant whether it should be done or not.
Note that the patch also changed the second arg when lookup called
ldap_search from "true" to false.

BEFORE:

basedn = 'cn=' . $SEARCH . ',' . $this->basedn;
filter = objectClass=*
scope  = base

AFTER:

basedn = $this->basedn
filter = $attr . '=' . $SEARCH
scope  = sub


So the original method would do an exact match and the later method would
do a subtree search for a match. The original method would be guaranteed
to match an LDAP entry added using the SQ LDAP interface while the latter
would match other entries as well (somewhere else in the hierarchy).

It's probably better to leave that part as it was for now (as you did in
your proposed patch which looks fine).

-- 
David Härdeman


-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: [email protected]
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel