Re: Patch for improved vCard support

Vincent,

> I have developed a patch for SquirrelMail 1.5.1 as available in debian.

When submitting patches to any project, you should always base it on
the code directly from that project.  1.5.1 is years old now and very
much deprecated (and I have no idea whether or not Debian modified the
code for their purposes).  Our current development stream is
1.5.2(svn), and any patches should be based on it (either do a SVN
checkout or grab a snapshot from our downloads page).

> This patch improves the support of vCard :
>  - display of vcards attached to mail with more fields (including PHOTO
> and LOGO), sorted by category (Personal, Work, Miscellaneous and
> Security)
>  - add vcards to identities in the options of the user's account
>  - attach the vcard when sending a mail
>
> The parsing of vcards is done using the pear module Contact_Vcard_Parse
> which does a better job that the "parser" that is currently in
> squirrelmail.

One of SquirrelMail's goals is to be easily installable and have an
extremely small set of requirements.  I'm not sure we'd want to add
this kind of requirement to our core.  You might investigate if any of
it can be done with a plugin or see if the built-in parser can be
extended.

> We did it as a patch and not a plugin to have it fully integrated into the
> webmail and to replace the code already written to display vcards attached
> to mails.
>
> The next step would be to save the vcards received as mail attachments
> into the address book.
>
> As it is my first patch against SquirrelMail, it may be far from being
> perfect. Any comments are welcome.

I haven't looked at it, but will see if I can find the time...  no
matter what ends up happening with it, your contribution is HIGHLY
appreciated!

Thanks!

  - Paul

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: [email protected]
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel