Re: Regression from 1.4.15 -> 1.4.17

* Paul Lesniewski <[email protected]>:

> In my reading, RFC does not require quoting of the "real" name (it is
> optional).

Yes, but if I send the mail using SM, it sends to:

Hildebrandt, ralf, [email protected]
-->
Hildebrandt@$mydomain, ralf@$mydomain, [email protected]

> However, the possible presence of the comma demands quotes in this
> application.

See :) ?

> The problem you see isn't a regression per se, it's the result of the
> fact that SM was fixed to actually obey the user configuration for how
> email addresses should be carried from the address book to the compose
> screen.... and it exposed this bug.

Good.  
> The fix has been committed to SVN, and is here (and pasted in below
> for your convenience):

Thanks. I'll try it.
> http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/branches/SM-1_4-STABLE/squirrelmail/functions/addressbook.php?view=patch&r1=13366&r2=13365&pathrev=13366
> 
> Thanks a lot for pointing this out.
> 
> Cheers,
> 
> Paul
> 
> 
> Index: functions/addressbook.php
> ===================================================================
> --- functions/addressbook.php   (revision 13343)
> +++ functions/addressbook.php   (working copy)
> @@ -353,9 +353,9 @@
>          global $data_dir, $username;
>          $addrsrch_fullname = getPref($data_dir, $username,
> 'addrsrch_fullname', 'fullname');
>          if ($addrsrch_fullname == 'fullname')
> -            return $row['name'] . ' <' . trim($row['email']) . '>';
> +            return '"' . $row['name'] . '" <' . trim($row['email']) . '>';
>          else if ($addrsrch_fullname == 'nickname')
> -            return $row['nickname'] . ' <' . trim($row['email']) . '>';
> +            return '"' . $row['nickname'] . '" <' . trim($row['email']) . '>';
>          else // "noprefix"
>              return trim($row['email']);
>      }
> 
> ------------------------------------------------------------------------------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
> The future of the web can't happen without you.  Join us at MIX09 to help
> pave the way to the Next Web now. Learn more and register at
> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
> -----
> squirrelmail-devel mailing list
> Posting guidelines: http://squirrelmail.org/postingguidelines
> List address: [email protected]
> List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
> List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel

-- 
Ralf Hildebrandt (i.A. des GB IT)               [email protected]
Charite - Universitätsmedizin Berlin            Tel.  +49 (0)30-450 570-155
Gemeinsame Einrichtung von FU- und HU-Berlin    Fax.  +49 (0)30-450 570-962
Geschäftsbereich IT Standort CBF                     I'm looking for a job!

------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: [email protected]
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel