Re: ANNOUNCE: SquirrelMail 1.4.20 Release Candidate 1 Now Available

>>>>> The SquirrelMail Team is pleased to bring you the first release
>>>>> candidate ahead of our next SquirrelMail version: 1.4.20RC1.  Because
>>>>
>>>> 1.4.20 Release Candidate 1 breaks searching mailboxes.
>>>> With 1.4.20RC1 I'm getting:
>>>>
>>>> FEHLER: Falsche oder ungültige Anfrage.
>>>> Anfrage: FETCH (FLAGS UID RFC822.SIZE INTERNALDATE
>>>> BODY.PEEK[HEADER.FIELDS
>>>> (Date To Cc From Subject X-Priority Importance Priority Content-Type)])
>>>> Server antwortete: Error in IMAP command UID FETCH: Invalid arguments.
>>>>
>>>> With 1.4.19 all works like a charm. Both instances are on the same
>>>> machine! The IMAP Server is dovecot 1.2.3
>>>
>>>Thanks for the report, Ralf.
>>>
>>>The problem is caused by a fix Jon added for the filters plugin:
>>>
>>>http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail?view=rev&revision=13789
>>>
>>>Specifically, the changes at line 208 in functions/imap_general.php in
>>>this patch are the problem:
>>>
>>>http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/branches/SM-1_4-STABLE/squirrelmail/functions/imap_general.php?r1=13733&r2=13789&view=patch
>>>
>>>To get your search functionality back, comment out or remove the two
>>>lines in those braces:
>>>
>>>$response = 'OK';
>>>break 2;
>>
>>This was why I posted, and asked for feedback before committing. I use
>>SM daily, but not extensively enough to cover all the areas enough.
>>
>>>
>>>Since Jon's head was already in it recently, I hope he can fix this.
>>>Jon, FWIW, a typical simple SEARCH conversation looks like:
>>>
>>>A05 SEARCH CHARSET ISO-8859-1 ALL FROM {4}
>>>+ OK
>>>test
>>>* SEARCH 6728 6301
>>>A05 OK SEARCH done.
>>
>>Thanks, I forgot to check the search section to see if the same bug
>>existed there, and it does.  The reason the error is coming up is
>>because part of the code is not handling literals (sending) properly.
>>It's sending it as a single string, without waiting for feedback from
>>the server (as required).  I'll take a peek, and see what I can do
>>with the search functionality too.
>
> http://netdork.net/imapsearch_fix.patch
>
> I've done some refactoring in the function, seemed to include a bit of
> duplication, and now calling the literals function I created
> previously.  There is a comment in there about macosx, and hmail not
> working properly, but I don't know why, I suspect it was the poor use
> of literals that was the cause.
>
> Anyway, if somebody could give this a good testing, and let me know,
> I'll get it committed.  Also get it rolled into the dev branch too.

It fixes things for me.  I'd love to see it in the dev branch.  ;-)


-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: [email protected]
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel