Re: Patch to allow compilation when unicode disabled

[email protected] Sun, 23 May 2004 15:20:01 GMT
Newsgroups gmane.mail.sqwebmail
Message-ID <[email protected]>
[email protected] writes: 

> Because of these error messages I got when compiling sqwebmail-4.0.4 when 
> using the  --disable-unicode option:  
> 
> Compiling maildir.c
> maildir.c: In function `subjectcmp':
> maildir.c:1491: error: `unicode_UTF8' undeclared (first use in this 
> function)
> maildir.c:1491: error: (Each undeclared identifier is reported only once
> maildir.c:1491: error: for each function it appears in.)
> maildir.c:1491: error: too many arguments to function 
> `rfc2047_decode_simple'
> maildir.c:1492: error: too many arguments to function 
> `rfc2047_decode_simple'
> make[3]: *** [maildir.o] Error 1  
> 
> -----------
> I made this patch, which works for me:  
> 
> 
> diff -u sqwebmail-4.0.4-patched/sqwebmail/maildir.c 
> sqwebmail-4.0.4/sqwebmail/maildir.c
> --- sqwebmail-4.0.4-patched/sqwebmail/maildir.c 2004-05-23 
> 03:11:09.519832936 -0600
> +++ sqwebmail-4.0.4/sqwebmail/maildir.c 2004-05-23 02:52:39.242829886 
> -0600
> @@ -1488,8 +1488,8 @@
>       as=rfc2047_decode_unicode(a, &unicode_UTF8, 0);
>       bs=rfc2047_decode_unicode(b, &unicode_UTF8, 0);
> #else
> -       as=rfc2047_decode_simple(a);
> -       bs=rfc2047_decode_simple(b);
> +       as=rfc2047_decode_simple(a, &unicode_UTF8);
> +       bs=rfc2047_decode_simple(b, &unicode_UTF8);
> #endif  
> 
>       if (as)  
> 
 

Looking at in the morning, obviously what I should have done was pass the 
files in different order to the diff command, so that: 

 -       as=rfc2047_decode_simple(a, &unicode_UTF8);
 -       bs=rfc2047_decode_simple(b, &unicode_UTF8);
+       as=rfc2047_decode_simple(a);
+       bs=rfc2047_decode_simple(b); 


Sorry for the confusion. 

 --
Scott Langley
[email protected]
Systems Administrator
Rural Network Services