Re: Re: charset independent preferences etc.

On Fri, 28 May 2004 21:50:07 -0400
Sam Varshavchik <[email protected]> wrote:

> You'll need to provide a better explanation, or refactor the patches 
> differently.  You are generating huge patches, with only a brief, one/two 
> sentence explanation for each one.
> 
> You'll need to provide a more detailed explanation for the amount of code 
> you're changing here.

Sorry for less words.  I wrote more detailed explanation (and
patches are updated).

================================================================
* sqwebmail-cvs20040531-mimeheader.patch

Unicode functions of RFC2047 header encoding.

rfc822/rfc2047u.c
  New funtions
    rfc2047_encode_unicode()
    rfc2047_encode_str_fromutf8()
    rfc2047_encode_header_fromutf8()
  which are Uniocde version of rfc2047_encode_str() and 
  rfc2047_encode_header().

  Note that rfc2047_encode_header_fromutf8() accepts data encoded 
  by UTF-8.  Codes calling this function must convert charset
  of header string to UTF-8 then parse it so that 7-bit multibyte 
  etc. strings won't broken.

rfc822/rfc2047.c
  a_rfc2047_encode(), base function of a_rfc2047_encode_str() 
  and a_rfc2047_encode_unicode().


* sqwebmail-cvs20040531-utf8pref.patch [depends on a patch above]

Read/write following files using UTF-8 so that configurations 
are charset independent:
  MAILDIR/sqwebmail-addressbook
  MAILDIR/sqwebmail-config
  MAILDIR/sqwebmail-ldapaddressbook
  MAILDIR/sqwebmail-sig
  SYSCONFDIR/ldapaddressbook

sqwebmail/ldaplist.c (login_fromhdr)
  login_fromhdr() now returns UTF-8 value.

sqwebmail/addressbook.c
sqwebmail/auth.c
sqwebmail/newmsg.c
sqwebmail/newmsg_create.c
sqwebmail/newmsg_newdraft.c
sqwebmail/pref.c
sqwebmail/folder.c
sqwebmail/pcp.c
  Changes on format of sqwebmail-addressbook [addressbook.c]:
    Special entries with key "<charset>:" determin charset of
    succeeding entries.  While "<charset>:" entry is not appeared,
    HTTP content charset is assumed for backward compatibility.

  Changes on format of sqwebmail-config [pref.c]:
    A prefix "+U" indicates that decoded preference string 
    is UTF-8.  No prefix indicates HTTP content charset, for 
    compatibility.

  Other changes on code [all]:
    Values of pref_from, pref_ldap and login_fromhdr() are UTF-8.
    Addrssbook functions accept UTF-8 arguments and return UTF-8 values.

sqwebmail/sqwebmail.c
sqwebmail/folder.c
  New helper functions
    output_attrencoded_fp_fromutf8()
    output_attrencoded_fromutf8()
    output_attrencoded_oknl_fp_fromutf8()
    output_attrencoded_oknl_fromutf8
    print_safe_to_stdout_fromutf8()
    print_safe_fromutf8()
  Which accept UTF-8 string arguments.


NOTE: Convert/update following files to UTF-8 (if needed):
    MAILDIR/sqwebmail-ldapaddressbook
    SYSCONFDIR/ldapaddressbook
    MAILDIR/sqwebmail-sig
  sqwebmail-addressbook and sqwebmail-config will be updated
  automatically.


* sqwebmail-cvs20040531-sqwebmail.patch

Some fixes and enhancements.

sqwebmail/folder.c
  Decode all shown header values.

  (print_header_uc)
    [fix] Header names will be HTML-escaped.
  (showmsgrfc822_body)
    [enh] Show Resent-Date: header in simple header mode.
    [enh] Decode values of non-address headers also.
    [enh] Preserve case of header names in full header mode.
  (showmsgrfc2369_header)
    [enh] Decode names/comments of RFC2369 headers.
    [enh] Replace special value "NO" of List-Post: header with
      template argument "LIST_POST_NO".

sqwebmail/folder.c
  (showtextplain)
    [fix] Use rfc2045_decodetextmimesection() instead of
      rfc2045_decodemimesection().
rfc2045/rfc2045reply.c
  (mkreply)
    [fix] Use rfc2047_decode_unicode() instead of rfc2047_decode_enhanced().
sqwebmail/pcp.c
  (sqpcp_eventstart)
  (sqpcp_print_event_subject)
    [fix] Use rfc2047_decode_unicode instead of rfc2047_decode_enhanced().


Known bugs

  - Brackets (<>) in address headers and RFC2369 headers
    will not be HTML-escaped.


  --- nezumi