[Slim-Checkins] r33918 - in /7.8/trunk/server: Changelog7.html Slim/Control/Commands.pm

Author: ayoung
Date: Wed Mar 28 01:49:58 2012
New Revision: 33918

URL: http://svn.slimdevices.com/slim?rev=33918&view=rev
Log:
Fixed bug 17758: Pop up symbols linger too long on the screen 

Do not set a duration of 10000 on jive show-brieflies for current song state, which are used for playlist jump events, just to ensure that the new track title is pushed to the first line of the display and stays there until a new playerStatus arrives (which can take quite a long time under some circumstances). This affected both the duration of the new title on the display and that of the the Play pop-up icon if the command was invoked via IR.  Having the popup hang around for 10s can be irritating. Given that the player has control of title change itself, it can set a long duration on just that element and use the default show-briefly duration for the popup.

Modified:
    7.8/trunk/server/Changelog7.html
    7.8/trunk/server/Slim/Control/Commands.pm

Modified: 7.8/trunk/server/Changelog7.html
URL: http://svn.slimdevices.com/slim/7.8/trunk/server/Changelog7.html?rev=33918&r1=33917&r2=33918&view=diff
==============================================================================
--- 7.8/trunk/server/Changelog7.html (original)
+++ 7.8/trunk/server/Changelog7.html Wed Mar 28 01:49:58 2012
@@ -13,6 +13,7 @@
 		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=8180">#8180</a> - Squeezecenter prevents user logout after restart </li>
 		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=17174">#17174</a> - Title info doesn't update correctly when multiple SBs are playing same station</li>
 		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=17729">#17729</a> - On Linux SBS 7.4.1 and above: service cannot be stopped or restarted after an 'internal' restart</li>
+		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=17758">#17758</a> - Pop up symbols linger too long on the screen</li>
 		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=17933">#17933</a> - Failure to parse m3u playlists with relative paths</li>
 	</ul>
 	<br />

Modified: 7.8/trunk/server/Slim/Control/Commands.pm
URL: http://svn.slimdevices.com/slim/7.8/trunk/server/Slim/Control/Commands.pm?rev=33918&r1=33917&r2=33918&view=diff
==============================================================================
--- 7.8/trunk/server/Slim/Control/Commands.pm (original)
+++ 7.8/trunk/server/Slim/Control/Commands.pm Wed Mar 28 01:49:58 2012
@@ -935,8 +935,21 @@
 	my $showStatus = sub {
 		my $jiveIconStyle = shift || undef;
 		if ($client->isPlayer()) {
-			my $parts = $client->currentSongLines({ suppressDisplay => Slim::Buttons::Common::suppressStatus($client), jiveIconStyle => $jiveIconStyle });
-			$parts->{'jive'}->{'duration'} = 10000 if $parts && $parts->{'jive'}; # 10s: nice and long to avoid bouncing displays
+			my $parts = $client->currentSongLines({
+					suppressDisplay => Slim::Buttons::Common::suppressStatus($client),
+					jiveIconStyle => $jiveIconStyle,
+				});
+				
+			# awy: We used to set $parts->{'jive'}->{'duration'} = 10000 here in order to
+			# ensure that the new track title is pushed to the first line of the display
+			# and stays there until a new playerStatus arrives. This can take quite a
+			# long time under some circumstances, such as with slow servers. However,
+			# setting the delay here affected both the duration of the new title on the
+			# display and that of the the Play pop-up icon if the command was invoked via IR.
+			# Having the popup hang around for 10s can be irritating (bug 17758). Given that
+			# the player has control of title change itself, it can set a long duration
+			# on just that element and use the default show-briefly duration for the popup.
+			
 			$client->showBriefly($parts, { duration => 2 }) if $parts;
 			Slim::Buttons::Common::syncPeriodicUpdates($client, Time::HiRes::time() + 0.1);
 		}