Re: LMS for Windows using Strawberry Perl

mherger wrote: 
> > The LMS installer should be able to be changed to handle the
> dependency
> > and install perl if it's not there, keeping in mind that we will be
> tied
> > to a specific version of SB Perl, just like Linux.
> 
> Good plan.
Great that's settled.  I can move forward now, no more compiled exes for
windows.

mherger wrote: 
> > However, I have no issues with moving to as close as possible to the
> > current win32 build system.  In which case it would be helpful to
> have
> > the version details for all the tools, sans the PDK of
> course.[/color]
> 
> I'm not sure I understand. As you might know the buildme.pl is 
> cross-platform. On Windows whomever started the work decided to base it
> 
> on cygwin, maybe just for the availability of all the same tools needed.
> 
> Are you using the same Strawberry Perl to run the script as you use for
> 
> LMS? Unless we want to move the 32 bit build to the same architecture 
> (getting rid of ActiveState tools), I'd like to keep the current 
> pipeline, as otherwise we'd have to tweak it even more to cover the two
> 
> different builds.
Yes, I'm fully aware of the fact that buildme.pl is cross platform. 
I've added the win64 build type to it.

I don't see any reason to move the 32bit build. I would think that at
some point we would stop providing the AS 32bit builds, since the PDK is
no longer supported.
In my mind the win32 bit build would eventually be retired.  How many
32bit windows 10+ installs are there.  You've already stopped provide
the windows 32bit spotty helper.

mherger wrote: 
> But maybe I'm overthinking this, and it actually doesn't really matter 
> much whether we use cygwin or the tools you're using. As long as there's
> 
> Perl, rsync and all the other tools, it should probably run just fine in
> 
> both environments? Or are the paths a problem?

I agree that it shouldn't matter.  But if I'm going to change to the
cygwin tools, it should be as close as possible to the version on the
current build system.
I've been bitten too many times, by changes to newer versions of tools
that break what had been works great for years. Trying to track down
what's changed is often a PITA.

mherger wrote: 
> > All sources and required changes are available in
> > https://github.com/ralph-irving/slimserver-vendor-win64 and
> > https://github.com/ralph-irving/slimserver-win64
> 
> Why didn't you fork the repositories?... this way it'll be much harder 
> to merge them. The two repositories could easily get out of sync...
I did this because the main repo is huge and all I need right now is the
windows specific binaries and modules.

I merge the changes from the official repo about once a week, unless,
you've applied a lot of changes, then I do it more often.
It's easy to export my repository and merge it into a branch of the
official repo, I've done it many times in the past for other projects.

mherger wrote: 
> I wanted to see the differences in Slim::Utils::OS::Win32 you applied -
> 
> but it's not easy with this setup to diff them. Would it make sense to 
> have a Win64 module or similar?

So far this is the only change I've made to that module.


Code:
--------------------
    
  @@ -122,8 +125,12 @@
  
  	# TODO: we might want to make this a bit more intelligent
  	# as Perl is not always in that folder (eg. German Windows)
  -
  -	Slim::Utils::Misc::addFindBinPaths('C:\Perl\bin');
  +	if ($] < 5.032001) {
  +		Slim::Utils::Misc::addFindBinPaths('C:\Perl\bin');
  +	}
  +	else {
  +		Slim::Utils::Misc::addFindBinPaths('C:\Strawberry\perl\bin');
  +	}
--------------------



I haven't tested if $FindBin::Bin would tell us what the executable is
for both windows perl versions yet.  I'll reply on github, once I know.
If it works, I can remove the version check as well and there's only one
other place remaining in my changes that checks the windows perl
version.



Ralphy

*1*-Touch, *5*-Classics, *3*-Booms, *2*-UE Radio
'Squeezebox client builds'
(https://sourceforge.net/projects/lmsclients/files/) 'donations'
(https://www.paypal.com/cgi-bin/webscr?cmd=_donations&business=LL5P6365KQEXN&lc=CA&item_name=Squeezebox%20client%20builds&currency_code=USD&bn=PP%2dDonationsBF%3abtn_donate_SM%2egif%3aNonHosted)
always appreciated.
------------------------------------------------------------------------
ralphy's Profile: http://forums.slimdevices.com/member.php?userid=3484
View this thread: http://forums.slimdevices.com/showthread.php?t=115740