Re: SimpleLibraryViews plugin update increases library build time by a factor of 10
Michael Herger <slim-b/[email protected]> Sun, 22 May 2022 11:37:06 +0200
| Newsgroups | gmane.music.equipment.slimdevices.devel |
|---|---|
| Message-ID | <[email protected]> |
> Perhaps not the most efficient way of doing it, but it basically mirrors
> what the original code does. It seems to work correctly.
Whatever works! Sometimes optimizations aren't worth the hassle. If
you're happy with the result then it's better to keep the code you
understand and know how to maintain.
> my $pathSearch = Slim::Utils::Misc::fileURLFromPath($dir) . File::Spec->catfile('', '') . "%";
I still believe this could fail on Windows. Would you have any Windows
testers? catfile() should not be used with a URL. Just use the forward
slash "/" instead.