Re: Strange behaviour of volume on synced players

mherger wrote: 
> Could you please try whether one of the following would change
> behavior?
> 
> - turn off Spotify Connect for a while. Also turn on INFO logging for
> plugin.spotty to see whether you see any volume notification around the
> time when this happens.
> - turn off the fixed volume on the Touch
> - make sure you don't have volume sync enabled

Might be here in StreamingController

Code:
--------------------
    
  	# Bug 18165: master's volume might not be the right one to use
  	my $masterVol;
  	foreach my $player (@{$self->{'players'}}) {
  		next unless $prefs->client($player)->get('syncVolume');
  		$masterVol = abs($prefs->client($player)->get("volume") || 0);
  		last;
  	}	
  	
  	my $startedPlayers = 0;
  	my $reportsTrackStart = 0;
  		
  	# bug 10438
  	$self->resetFrameData();
  	
  	# fade-in has precedence over crossfade only player is stopped
  	$self->{'fadeActive'} = $fadeIn < 1 && $self->{'playingState'} == STOPPED && $prefs->client($self->master)->get('fadeInDuration');
  	
  	foreach my $player (@{$self->{'players'}}) {
  		if ($self->{'playingState'} == STOPPED) {
  			# Bug 10310: Make sure volume is synced if necessary
  			my $vol = ($prefs->client($player)->get('syncVolume'))
  				? $masterVol
  				: abs($prefs->client($player)->get("volume") || 0);
  			$player->volume($vol);
  			# can't fade_volume here as we might not be playing yet so ramp-up would be lost
  			$player->volume(0,1) if $self->{'fadeActive'};
  		}	
  
--------------------


I changed that a while ago to make sure we use the volume of the a
proper player (one that is supposed to propagate sync and sync master
might not) but maybe in addition we should check that the selected
player has not fixed volume. Although, that's really a user's fault IMHO



LMS 8.2 on Odroid-C4 - *SqueezeAMP!*, 5xRadio, 5xBoom, 2xDuet, 1xTouch,
1xSB3. Sonos PLAY:3, PLAY:5, Marantz NR1603, Foobar2000, ShairPortW,
2xChromecast Audio, Chromecast v1 and v2, Squeezelite on Pi,  Yamaha
WX-010, AppleTV 4, Airport Express, GGMM E5, RivaArena 1 & 3
------------------------------------------------------------------------
philippe_44's Profile: http://forums.slimdevices.com/member.php?userid=17261
View this thread: http://forums.slimdevices.com/showthread.php?t=116783