Re: done in HTTP.pm
Sean Adams <[email protected]>
| Newsgroups | gmane.music.equipment.slimp3.dev |
|---|---|
| Message-ID | <[email protected]> |
Dean, For the time being, yes. There are still some things needed (see commit log) but I'll stay out of your way. Let me know if you have any ideas for the template language. Maybe: [BIF foo=bar]...[/BIF] -> <b>...</b> if foo eq bar else ... Everyone, In general (not just HTTP.pm), it seems like we're now repeating an awful lot of machinery for checking if something is a directory/file/m3u/pls, whether we can descend into it, how to load the next item, and so on. Also I noticed some strange things like the "add" command for a dirctory but "append" but a single item, likewise for "load" and "play". We should be able to generalize all of these operations, but when we can't, we shouldn't use synonyms for the names of the different functions! Maybe add_directory and add_file or something. Also there are lots of places where variable naming is confusing, or the semantics of a variable or function are neither obvious nor commented. Especially with regard to paths - many functions take absolute file system paths as arguments, and they really shouldn't. Everywhere except in the file test/open/close/readdir functions, we should only handle paths relative to mp3dir. This is not just a style/consistency thing - there are security implications when exposing full paths via playlists, HTTP interface, etc. Keeping them out of the code and the user interface wherever possible is cleaner and safer. Sean On Mon, 22 Oct 2001, dean blackketter wrote: > Hey Sean, > > Are you done working HTTP.pm? > > I was going to start working on it a little bit, but didn't want to > get in your way. > > -dean > > > To unsubscribe from this group, send an email to: > [email protected] > > > > Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/ > > > ------------------------ Yahoo! Groups Sponsor ---------------------~--> Pinpoint the right security solution for your company- Learn how to add 128- bit encryption and to authenticate your web site with VeriSign's FREE guide! http://us.click.yahoo.com/yQix2C/33_CAA/yigFAA/rIp0lB/TM ---------------------------------------------------------------------~-> To unsubscribe from this group, send an email to: [email protected] Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/