RE: IP Filtering Patch

Here's a setup tip:
The PrefHead will default to "SETUP_" . uc($prefname)
The PrefDesc will default to "SETUP_" . uc($prefname) . "_DESC"

So, if you name the strings appropriately, you don't have to set these
values in the setup hash.  So, for this latest pref:
use SETUP_ALLOWLOCALHOST instead of SETUP_ALLOWLOCAL_HEAD
and SETUP_ALLOWLOCALHOST_DESC instead of SETUP_ALLOWLOCAL_DESC

Then you can leave out these lines:
+						,'PrefHead' =>
string('SETUP_ALLOWLOCAL_HEAD')
+						,'PrefDesc' =>
string('SETUP_ALLOWLOCAL_DESC')

Since we seem to have a ton of true/false options with strings attached, I'm
thinking about defaulting the options key as well (to 0 => "SETUP_" .
uc($prefname) . "_0" , 1 => "SETUP_" . uc($prefname) . "_1")

Robert

> -----Original Message-----
> From: Metzger, Michael [mailto:[email protected]]
> Sent: Thursday, February 20, 2003 9:48 AM
> To: '[email protected]'
> Subject: RE: [slimp3-dev] IP Filtering Patch
> 
> 
> Ok, this patch applies to CVS as of this morning (02/20/03) 
> and implements
> the following:
> 
> - Option to allow/disallow local IP addresses to connect 
> (127.0.0.1, any
> local IP, etc) (enabled by default)
> - Removal of 127.0.0.1 from always being listed in allowed IPs
> - Text cleanup based on new option
> 
> Mike
> 
> 
> 
> -----Original Message-----
> From: Metzger, Michael [mailto:[email protected]]
> Sent: Thursday, February 20, 2003 11:14 AM
> To: '[email protected]'
> Subject: RE: [slimp3-dev] IP Filtering Patch
> 
> 
> Working on it as we speak.  To suit everyone, I've added an additional
> option of "Allow Local IPs" to either implicitly allow every 
> IP aliased on
> the system, or block them.  If you block them, you can still 
> explicitly
> define certain sources.  
> 
> Should hopefully have something soon, but my job keeps 
> getting in the way...
> ;)
> 
> Mike
> 
> -----Original Message-----
> From: dean blackketter [mailto:[email protected]]
> Sent: Thursday, February 20, 2003 11:12 AM
> To: [email protected]
> Subject: Re: [slimp3-dev] IP Filtering Patch
> 
> 
> Fair enough.
> 
> By default the local machine addresses should be allowed.
> 
> The current CVS tree always adds 127.0.0.1, even if you 
> delete it AND  
> blocks connections from the local machine even if 127.0.0.1 
> is allowed  
> (as they appear to come in on the adaptor's address.)
> 
> Patches, anyone?
> 
> -dean
> 
> On Thursday, February 20, 2003, at 07:28  AM, Karl Auer wrote:
> 
> > On Thu, 20 Feb 2003 07:53:22 -0800
> > dean blackketter <[email protected]> wrote:
> >> I think that the local host (and all it's aliases) should always be
> >> allowed and shouldn't even appear.
> >
> > Heavens, no! On a Unix machine, who's to say all the users 
> are trusted?
> >
> > Please leave this settable, or at least only open in 
> conjunction with  
> > active password protection.
> >
> > Regards, K.
> >
> > --
> > 
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~
> > Karl Auer (kauer-Va/[email protected])                   
> +41-43-2660706 (h)
> > http://www.biplane.com.au/~kauer/                  +41- 
> 1-6327531 (w)
> >
> > ------------------------ Yahoo! Groups Sponsor  
> > ---------------------~-->
> > Get 128 Bit SSL Encryption!
> > http://us.click.yahoo.com/FpY02D/vN2EAA/xGHJAA/rIp0lB/TM
> > 
> --------------------------------------------------------------------- 
> > ~->
> >
> > To unsubscribe from this group, send an email to:
> > [email protected]
> >
> >
> >
> > Your use of Yahoo! Groups is subject to  
> > http://docs.yahoo.com/info/terms/
> >
> >
> 
> 
> 
> To unsubscribe from this group, send an email to:
> [email protected]
> 
>  
> 
> Your use of Yahoo! Groups is subject to 
http://docs.yahoo.com/info/terms/ 



To unsubscribe from this group, send an email to:
[email protected]

 

Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/ 




To unsubscribe from this group, send an email to:
[email protected]

 

Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/ 


------------------------ Yahoo! Groups Sponsor ---------------------~-->
Get 128 Bit SSL Encryption!
http://us.click.yahoo.com/FpY02D/vN2EAA/xGHJAA/rIp0lB/TM
---------------------------------------------------------------------~->

To unsubscribe from this group, send an email to:
[email protected]

 

Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/