Bug report: ArgusGetServerSocket

Richard Rothwell via Argus-info <[email protected]> Fri, 1 Jul 2016 01:17:37 +0000

Newsgroups	gmane.network.argus
Message-ID	<[email protected]>

Hi Carter,

Going through the code. Stumbled on this line 1034 in argus_client.c


   switch (input->type) {
      case ARGUS_DATA_SOURCE:
      case ARGUS_V2_DATA_SOURCE: {

if ((input->type == ARGUS_CISCO_DATA_SOURCE) || (input->mode == ARGUS_DATAGRAM_SOURCE)) {

Seems to me the test for ARGUS_CISCO_DATA_SOURCE won’t ever be true if the case statement has already determined type to be something else.


Regards