Re: TLS profile

Andrea Campi <[email protected]> Fri, 26 Jul 2002 11:15:05 +0200
Newsgroups gmane.network.beep.roadrunner.general
Organization I.NET S.p.A.
Message-ID <[email protected]> 
On Thu, Jul 25, 2002 at 07:08:19PM +0200, Jonas Borgstr?m wrote:
> 
> server_init was known as "validate_piggyback" in the 0.8 release.
> 
> The api change is basically that some virtual functions are renamed
> and their arguments changed.
> 
[...]
> 
> And that the RRProfile type is removed and the profile specific
> functions and members are moved into RRChannel.
> 

Well, I took the hint and I am currently moving our development to
the CVS version ;-)

In doing so I had to patch a couple of files to get a clean build
on our AIX 4.3 machines (well actually librr/tcp/rr-tcpconnection.c
only gave warnings, while rr-sasl.c didn't actually compile).
Would you look into them and see if it's possible to commit them
or something similar?

Bye,
	Andrea

-- 
Andrea Campi                              mailto:[email protected]
I.NET S.p.A.                              http://www.inet.it
Direzione Tecnica - R&D			  phone: +39 02 32863 ext 1
v. Darwin, 85 - I-20019			  fax: +39 02 32863 ext 7705
Settimo Milanese (MI), Italy
rr-tcpconnection.c.diff (text/plain, 871 B) 
==== //depot/roadrunner_inet/librr/tcp/rr-tcpconnection.c#1 - /src/acampi/ws/roadrunner_inet/librr/tcp/rr-tcpconnection.c ====
@@ -91,8 +91,8 @@
 	RRTCPConnection *tcpc = (RRTCPConnection *)object;
 
 	tcpc->iochannel = NULL;
-	tcpc->ibuffer = g_new (gint8, BUFFER_SIZE);
-	tcpc->obuffer = g_new (gint8, BUFFER_SIZE);
+	tcpc->ibuffer = g_new (gchar, BUFFER_SIZE);
+	tcpc->obuffer = g_new (gchar, BUFFER_SIZE);
 	tcpc->ibuffer_offset = 0;
 
 	g_static_mutex_init (&tcpc->event_lock);
@@ -521,7 +521,7 @@
 	RRConnection *conn;
 	GIOStatus status;
 	GError *error = NULL;
-	gint read;
+	guint read;
 
 /* 	g_print ("in_event: %p condition = %0x\n", data, condition); */
 
@@ -583,7 +583,7 @@
 		return FALSE;
 	}
 	else {
-		gint len, written;
+		guint len, written;
 		
 		len = rr_frame_build (frame, tcpc->obuffer);
 		status = rr_filterstack_write (conn->filter_stack,
rr-sasl.c.diff (text/plain, 1.3 KB) 
==== //depot/rrsasl_inet/librrsasl/rr-sasl.c#1 - /src/acampi/ws/rrsasl_inet/librrsasl/rr-sasl.c ====
@@ -404,7 +404,8 @@
 	const gchar *mech;
 	const gchar *data;
 	const gchar *chosenmech;
-	gint r, len;
+	guint len;
+	gint r;
 
 	mech = rr_sasl_get_mech (G_OBJECT_TYPE (sasl));
 	len = strlen (mech);
@@ -425,7 +426,8 @@
 		gboolean piggyback, GError **error)
 {
 	const gchar *data;
-	gint r, len;
+	guint len;
+	gint r;
 
 	r = sasl_client_step (sasl->sasl_conn, blob, blob_len, NULL, 
 			      &data, &len);
@@ -445,7 +447,8 @@
 {
 	const gchar *mech;
 	const gchar *data;
-	gint r, len;
+	guint len;
+	gint r;
 
 	if (blob_len == 0)
 		blob = NULL;
@@ -480,7 +483,8 @@
 		gboolean *done, gboolean piggyback, GError **error)
 {
 	const gchar *data;
-	gint r, len;
+	guint len;
+	gint r;
 
 	r = sasl_server_step (sasl->sasl_conn, blob, blob_len, &data, &len);
 
@@ -735,13 +739,14 @@
 {
 	RRChannel *channel = RR_CHANNEL (sasl);
 	RRTCPConnection *tcpc = RR_TCP_CONNECTION (channel->connection);
-	struct sockaddr_storage local_ip, remote_ip;
+	struct sockaddr local_ip, remote_ip;
 	gchar localaddr[NI_MAXHOST + NI_MAXSERV];
 	gchar remoteaddr[NI_MAXHOST + NI_MAXSERV];
 	gchar hbuf[NI_MAXHOST], pbuf[NI_MAXSERV];
 	gchar myhostname[NI_MAXHOST + 1];
 
-	gint fd, salen, r;
+	gulong salen;
+	gint fd, r;
 
 	fd = rr_tcp_connection_get_fd (tcpc);