Re: RRIDXP 0.2 compile prob on RH 7.3 and quick and dirtyworkaround

Sandro Poppi <[email protected]> Sat, 28 Sep 2002 15:00:25 +0200
Newsgroups gmane.network.beep.roadrunner.idxp
Message-ID <[email protected]>
Hi Ryan,

just to make clear: What I commented out was the #ifdef
G_HAVE_ISO_VARARGS part leaving G_HAVE_ISO_VARARGS as it was (ok,
deleted the #elif of course ;)

But thanks for the hint: For our own programs we will use the ...,
NULL); workaround on any rr_debug statement!

Si long,
Sandro
> 
> Hi Sandro,
> 
> I can confirm this behavior on redhat 7.3
> I meant to research and submit a patch but I never got around to it.
> I found that on my system the errors were caused by rr_debug statements
> which only had a format parameter and not any variables to be formated.
> In example rr_idxp.c:156 :
>   rr_debug3 ("idxp::set_greeting_active: Mutex unlocked\n");
> 
> after running the preprocessor the rr_debug statement above got expanded to:
>   g_log ("RR", RR_LOG_LEVEL_DEBUG3, "idxp::set_greeting_active: Mutex
> unlocked\n",);
> 
> Instead of commenting the lines out I found that adding a NULL to the
> end seemed to work:
>    rr_debug3 ("idxp::set_greeting_active: Mutex unlocked\n", NULL);
> 
> I'm sure there is a way to have something like this done automatically
> in rr-debug.  There are also some statements like this in rrtls too.
> 
> Ryan
-- 
"Linux is like a wigwam: no windows, no gates ... apache inside!"

http://spoppi.home.pages.de/
http://www.lug-burghausen.org/