Re: cacti-0.8.8b: Multiple COMMENT arguments in "rrdtool graph" ??

On 08.08.2013 09:45, Marc-Christian Petersen wrote:
> Hi Christian,
> 
> Am 08.08.2013 um 8:55:27 Uhr schrieb Christian Adler <[email protected]>:
> 
> 
>> after upgrading to 0.8.8b we have problems with some thumbnail graphs.
>> In the logfile we found:
>> This results in "ERROR: Expected some arguments after 'COMMENT:'" and no
>> thumbnail displayed.
>> Why are there three COMMENT-arguments in this command??
>> How can we fix it?
> 
> yep, there seems to be something fishi.
> 
> All COMMENTS with <HR> are now nothing instead of empty newlines
> like in every release before.
I tried to reproduce:
1. A COMMENT using text "bla" without HR works fine
2. A COMMENT using text "bla" with HR works fine
3. A COMMENT using text "" without HR breaks due to missing argument (rrdtool
seems to require at least a blank)
4. A COMMENT using text "" with HR does not break but does not display an empty
line as it should

IMHO, a completely empty COMMENT does not make THAT much sense. But as we allow
for $graph_variable replacement, this is a condition that finally may occur,
nevertheless.
Will look for a fix.
Thanks for reporting this bug and the analysis
Reinhard

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk