Re: (no subject)

Hi Trunk,

Thanks for your intrest in fixing cacti.

If I am not mistaken, you fixed a well known bug in 0.8.8b with a patch
already available for quite some time:
http://forums.cacti.net/viewtopic.php?p=243461#p243461

Paul

On 04-04-14 21:14, [email protected] wrote:
> Hi all! I found bug in leatest stable version cacti 0.8.8b was installed today.
> 
> When i making graphs from http://forums.cacti.net/viewtopic.php?f=12&t=11020 all works fine without one piece.
> When i opening graph preview of host with that graph, my preview was not display images, but if i open link of this broken image then graphs works fine.
> 
> After debug function i was found bug place and fix it.
> 
>  patch for file lib/rrd.php
> 
> @@ -1347,14 +1347,14 @@
>                                  $comment_string = $graph_item_types{$graph_item["graph_type_id"]} . ":" . str_replace(":", "\:", cacti_escapeshellarg($graph_variables["text_format"][$graph_item_id] . $hardreturn[$graph_item_id])) . " ";
>                                  if (trim($comment_string) == 'COMMENT:"\n"') {
>                                          $txt_graph_items .= 'COMMENT:" \n"'; # rrdtool will skip a COMMENT that holds a NL only; so add a blank to make NL work
> - } else if (trim($comment_string) != "COMMENT:\"\"") {
> + } else if ((trim($comment_string) != "COMMENT:\"\"")&&(trim($comment_string) != "COMMENT:''")) {
>                                          $txt_graph_items .= rrd_substitute_host_query_data($comment_string, $graph, $graph_item);
>                                  }
>                          }else {
>                                  $comment_string = $graph_item_types{$graph_item["graph_type_id"]} . ":" . cacti_escapeshellarg($graph_variables["text_format"][$graph_item_id] . $hardreturn[$graph_item_id]) . " ";
>                                  if (trim($comment_string) == 'COMMENT:"\n"') {
>                                          $txt_graph_items .= 'COMMENT:" \n"'; # rrdtool will skip a COMMENT that holds a NL only; so add a blank to make NL work
> - } else if (trim($comment_string) != "COMMENT:\"\"") {
> + } else if ((trim($comment_string) != "COMMENT:\"\"")&&(trim($comment_string) != "COMMENT:''")) {
>                                          $txt_graph_items .= rrd_substitute_host_query_data($comment_string, $graph, $graph_item);
>                                  }
>                          }
> 
> I hope my fix help make cacti rater.
> 
> ------------------------------------------------------------------------------
> _______________________________________________
> cacti-user mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/cacti-user
>

------------------------------------------------------------------------------

_______________________________________________
cacti-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cacti-user

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Icedove - http://www.enigmail.net/

iQEcBAEBCAAGBQJTQBWkAAoJEJxcmesFvXUKbHwH/jLH5UFfMEuG0LNh7phQm/WA
b+KlOjNPIzipd322IPFvAoktKyZ1EuJa+bM+hYxpHfjAfzTih168cedQ6PTafBGh
zJAfsYs7JK4xB+tpGyjDc/OZ0TZdMPtJlsQDu0JBF03Q0C2uy/TEtM+H+05XwO4I
PblWRFaR/Imqyr0pRyB0QXkp7uAXGai7s4vy7BmBPa7v94w6Ty5I/ZtfLJ04sSSH
Bv5HWD3ya6y60a69YQhJ2L7GOLUGW5U2+c77smXpOsR1p25b7wKg4ufDnAzq1syg
DX9SR2EVNRexjGHIf4VcCtMhC0ef02teCwHTTv5gE1tvovLvFEMiJCDxCWuiROM=
=XHsm
-----END PGP SIGNATURE-----