Re: patch, getting rid of some compiler errors

David Riebenbauer <[email protected]> Fri, 16 Mar 2007 08:13:55 +0100
Newsgroups gmane.network.centericq
Message-ID <[email protected]>
* HÃ¥kan Kvist <[email protected]> [2007-03-09 22:05]:
> This patch is just for decreasing the number of gcc warnings.

Well, just cleaning up code is a good and useful too.

> Faild to setup my git-repository correct, so I couldn't commet
> directly to the right branch of the repository...

Actually it didi work, except that it seems that you didn't set your
username and email right. So I commited it again, from your email.

I think the changes are fine too.

> diff --git a/connwrap/connwrap.c b/connwrap/connwrap.c
> index 9159d85..0aac76d 100644
> --- a/connwrap/connwrap.c
> +++ b/connwrap/connwrap.c
> @@ -1,12 +1,15 @@
>  #include "connwrap.h"
>  
> -#include <netdb.h>
> -#include <string.h>
> -#include <netinet/in.h>
> -#include <errno.h>
>  #include <arpa/inet.h>
> +#include <errno.h>
>  #include <fcntl.h>
> +#include <netdb.h>
> +#include <netinet/in.h>
> +#include <string.h>
> +#include <stdio.h>
> +#include <stdlib.h>
>  #include <sys/time.h>
> +#include <unistd.h>

The only question I have really is about this part. Any specific
reason to reorder the includes like this?

Thanks
David

-- 
David Riebenbauer
Jabber: [email protected] - ICQ: 322056002

_______________________________________________
Cicq mailing list
Cicq-xGejAJT2w6wWP6gT/[email protected]
http://mailman.linuxpl.org/mailman/listinfo/cicq
Questions? Check the FAQ first: http://centericq.de/faq/
signature.asc (application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFF+kOzMM9MqQG0tAARApMnAKCYxk58VFRjecs2bbivQlyvwtxw5ACbBF2B
7y3A6DA6rCDRwtMFl0kDqZs=
=whbT
-----END PGP SIGNATURE-----