Re: Cricket on OS X 10.8 Mountain Lion

Just a follow up here. While working on getting mtargets working (still not
sure if it's just me using it incorrectly...) I found another part of
grapher.cgi that is handling an undefined 'view' correctly (see quoted
email below). It looks like this is what needs to happen to line 233:

--- /Users/davidoff/Downloads/cricket-1.0.5/grapher.cgi 2004-02-06
09:27:34.000000000 -0700
+++ ./grapher.cgi 2012-11-09 21:10:02.000000000 -0700
@@ -230,7 +230,8 @@

             # put the view into the target dict, so it's
             # there if they want to use it.
-            my($view) = lc $gQ->param('view');
+            my($view) = $gQ->param('view');
+            $view = lc $view if defined $view;
             if (defined($view)) {
                 $targRef->{'auto-view'} = $view;
             }

Refer to line 1363 for where I saw how this was being handled correctly
elsewhere.

Andy

On Sun, Nov 4, 2012 at 6:52 PM, Andrew Davidoff <[email protected]> wrote:

> Before I get into the specifics of the install, I should note that I ran
> into one issue related to targetTypes that don't contain a "view"
> dictionary. Whether this is my fault or a bug, I am not sure.
>
> On line 233 of grapher.cgi we have this:
>
> my($view) = lc $gQ->param('view');
>
> Following that assignment, various statements check to see if $view is
> defined. It appears as though "lc" is returning an empty string (i.e. $view
> is defined) in the case of $gQ->param('view') being undefined, which breaks
> display of targets that aren't views. I am currently only using a single
> target that does use a targetType that contains a view dictionary, so I
> have essentially worked around this (for now).
>
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov