[[email protected]: Bug#205144: directory-administrator: segfault on startup]

Hi, a debian user has found a problem, and is sending a patch to 
the debian BTS: for him DA segfaults on startup, due to a missing NULL in a
call to g_strconcat, so he is submitting a patch against DA.

Here is the patch, for review. I am submitting it to the patch manager too.

Thanks,

Guido

----- Forwarded message from Ian Wienand <[email protected]> -----

Subject: Bug#205144: directory-administrator: segfault on startup
To: Debian Bug Tracking System <[email protected]>
Date: Wed, 13 Aug 2003 11:28:39 +1000

Package: directory-administrator
Version: 1.5.1.0-1
Severity: normal

directory_administrator was segfaulting on startup for me due 
to a forgotten NULL in g_strconcat.  

Suggested patch attached.

-i
[email protected]
http://www.gelato.unsw.edu.au

-- System Information:
Debian Release: testing/unstable
Architecture: powerpc
Kernel: Linux mingus 2.4.21-ben2 #1 Sat Aug 9 02:40:55 EST 2003 ppc
Locale: LANG=C, LC_CTYPE=C

Versions of packages directory-administrator depends on:
ii  gdk-imlib1                  1.9.14-13    imaging library for use with gtk (
ii  libart2                     1.4.2-14     The GNOME canvas widget - runtime 
ii  libaudiofile0               0.2.3-4      The Audiofile Library
ii  libc6                       2.3.1-17.0.2 GNU C Library: Shared libraries an
ii  libdb3                      3.2.9-19     Berkeley v3 Database Libraries [ru
ii  libesd0                     0.2.29-1     Enlightened Sound Daemon - Shared 
ii  libglib1.2                  1.2.10-9     The GLib library of C routines
ii  libgnome32                  1.4.2-14     The GNOME libraries
ii  libgnomesupport0            1.4.2-14     The GNOME libraries (Support libra
ii  libgnomeui32                1.4.2-14     The GNOME libraries (User Interfac
ii  libgtk1.2                   1.2.10-16    The GIMP Toolkit set of widgets fo
ii  libldap2                    2.1.22-1     OpenLDAP libraries
ii  libssl0.9.7                 0.9.7b-2     SSL shared libraries
ii  xlibs                       4.2.1-9      X Window System client libraries

----- End forwarded message -----

--- directory-administrator-1.5.1.0/src/appfunctions.c	2003-06-12 23:04:05.000000000 +1000
+++ directory-administrator-1.5.1.0-fixed/src/appfunctions.c	2003-08-13 11:23:55.000000000 +1000
@@ -608,7 +608,7 @@
  app_set_status(message);
  g_free(message);
 
- message=g_strconcat("Directory administrator: ",connection_profile_get_name(current_connection_profile));
+ message=g_strconcat("Directory administrator: ",connection_profile_get_name(current_connection_profile),NULL);
  gtk_window_set_title(GTK_WINDOW(app),message);
  g_free(message);
  }