Re: File descriptor leak in tdlookup.c:respond
Mark Johnson <[email protected]>
| Newsgroups | gmane.network.djbdns |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Feb 17, 2009 at 4:01 PM, Matthew Dempsky <[email protected]> wrote: > On Tue, Feb 17, 2009 at 1:56 PM, Mark Johnson <[email protected]> wrote: >> On Tue, Feb 17, 2009 at 3:45 PM, Jeff King <[email protected]> wrote: >>> It looks like the only person who had a problem with this in practice >>> was doing a "cp" over his cdb file. >> >> What's a reasonable course of action in this situation? Log 'cdb is >> horked' and keep going? > > Free the cdb structure, close the file descriptor, and return 0. > server.c will write a - entry in the logs. Sounds like a plan. There was a patch in the original thread. Does it look correct to you? > Users shouldn't update their cdb in place anyway. It causes downtime > for DNS queries. Agreed. If they shoot their own foot off, though, tinydns shouldn't make things worse by leaking file descriptors. 8)