Re: [Zinq-general] Patch to open data.cdb no more than once per second
Jos Backus <[email protected]>
| Newsgroups | gmane.network.djbdns |
|---|---|
| Message-ID | <[email protected]> |
Hallo Harm, On Thu, Mar 26, 2009 at 11:54:08PM +0100, Harm van Tilborg wrote: > That's not the purpose of this patch. > > It's there to decrease the number of times a open(2) and mmap(2) is > called. Usually tinydns does this every x queries (right?). If you have > a high-traffic/load server, this could eventually be done at a much > higher rate (>1/s). I thought tinydns always reopens data.cdb on every query, and this patch changes it to not do that as often. It makes sense to only reopen it if has changed (by stat()ing it), and rate-limit that. So I'm curious if there are cases where data.cdb is updated more than once per second - it doesn't seem like a good fit for a 'constant' database. Maybe I misunderstand. > -- > Kind regards, > Harm van Tilborg > > Jos Backus wrote: > > On Thu, Mar 26, 2009 at 04:43:02PM -0500, Mark Johnson wrote: > >> Any opposition to this patch? > >> > >> http://marc.info/?l=djbdns&m=108229203212517&w=3 > > > > It seems to violate POLA. And are there really cases where people update > > data.cdb multiple times per second and want this behavior? > > -- Jos Backus jos at catnook.com