Re: [PATCH] dnscache: merge similar outgoing udp packets
Mark Johnson <[email protected]>
| Newsgroups | gmane.network.djbdns |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Apr 1, 2009 at 9:10 AM, Jeff King <[email protected]> wrote: > Because this change affects the dns library itself, this > change can potentially affect not just dnscache, but all of > the diagnostic tools. To address this, merging must be > enabled explicitly by the caller; dnscache will enable > merging if the MERGEQUERIES environment variable is set. Recommended value for MERGEQUERIES? Obviously dnscache doesn't care, but envdir will not set an environment variable if the corresponding file is empty. I'd be tempted to just use '1' or 'ON' except that suggests you can turn query merging off by setting it to '0' or 'OFF', when what they really have to do is remove the file or truncate it to zero bytes. Is there a best practice? I do intend to modify dnscache-conf to create a MERGEQUERIES file in the env directory so that query merging is on by default in zinq-djbdns.