Re: can anybody review my patchset?

On Mon, Apr 20, 2009 at 12:29 AM, Andreas Schulze
<[email protected]> wrote:
> 8. own Patch: decrease CacheTTL to force an nearly uncaching dnscache

Seems fine.  Weird variable names and error messages.

> 9. own Patch: let tinydns rotate multiple MX records

This patch is bad.  There's a buffer overflow if you serve MX records
with names over 128 bytes.  If you have over 8 MX records for a name,
it will always discard records after the first 8.  The shuffling
algorithm can take much longer than necessary; in particular, it goes
into an infinite loop if "." is used as a mail server name.

Also, not serving all MX records can potentially result in mail loops.
 (But technically this is true about not serving all A records too,
which tinydns does already.)

What's the motivation for these two patches?