Re: Patches to have dnscache listen on multiple IP addresses
Matthew Dempsky <[email protected]>
| Newsgroups | gmane.network.djbdns |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Oct 16, 2009 at 3:14 PM, Mark Johnson <[email protected]> wrote: > http://danp.net/djbdns/dnscache-1.05-multiple-ip.patch I don't see any real problems with this patch. Some nitpicks though: The code for parsing the IP environment variable seems a little goofy, but it works. I'd rather use a flat array of interf objects rather than a linked list. You can easily reuse gen_allocdefs.h for this; e.g., see address_alloc in pickdns-data.c. The log_listen() log entries seem unnecessary.