Re: [MaraDNS list] Patches

On 15/07/11 17:42, Sam Trenholme wrote:
> On second thought, it is not a serious issue.  Yarin's functionality is
> only documented in the Deadwood version of Duende, so you're only
> breaking undocumented features in the MaraDNS version of Duende.  

Thanks. That removes one task from the todo list.

> 
> If you feel like documenting it, doc/en/source/duende.ej is the file to
> edit.  The format is described in doc/en/source/ej.doc.format

The first problem is that until Debian has caught up (and the patches
can be rationalized) even contemplating editing the source documentation
is more hassle then it is worth.
At the moment when I make changes to the docs I merely patch the man
pages. The web pages are distributed as well but are not patched.

To be in a position where we build the documentation from the .ej files
is a small task in itself. For a start it needs to generate man pages
that do not require further patching. At the moment there are two
systemic issues:

1.) Some of the hyphens in the man pages get flagged up by the QA tools
as needing to be changed to '\-'. I don't know enough about roff to be
sure what the problem is. The title line is the one bit that gets hit by
this every time.
2.) Some of the syntax lines do not have sufficiently rich formatting. I
have added that in directly into the man pages.

I send you the modified man page for duende.

> 
> - Sam
> 
> 2011/7/15 Nicholas Bamber <[email protected]
> <mailto:[email protected]>>
> 
>     Well Yarin's patch never has been and never will be in Debian on its
>     own. However I was just thinking that it should not be too hard to put
>     backwards compatibility back into the source code. I could even #ifdef
>     it out on Debian.
> 
> 
>     On 15/07/11 02:17, Sam Trenholme wrote:
>     > I think having compatibility with older versions of Duende is
>     important;
>     > it's OK to have undocumented features.  It's less OK to break how
>     > something has been working in a minor bugfix release; it's even
>     less OK
>     > to have a feature that does not work as documented.
>     >
>     > - Sam
>     >
>     > 2011/7/14 Nicholas Bamber <[email protected]
>     <mailto:[email protected]>
>     > <mailto:[email protected] <mailto:[email protected]>>>
>     >
>     >     Sam,
>     >            YEs my patch builds on (and practically overwrites)
>     Yarins. I
>     >     can send
>     >     you the final duende.c file if tat would be better. I have a
>     separate
>     >     patch for documentation but unfortunately I cannot really
>     define one for
>     >     the doc source as things stand. Also I don;t think my patch is
>     100%
>     >     compatible with Yarin's. His requires a '=' after the '--pid'
>     and I
>     >     believe  mine unfortunately does not allow one.
>     >
>     >     On 14/07/11 20:08, Sam Trenholme wrote:
>     >     > Thank you for the patches.  My plan is to apply this patch
>     to the
>     >     > Deadwood version of Duende, and, if it works, percolate the
>     patch down
>     >     > in to MaraDNS.  Also, make sure this patch is applied to the
>     >     version of
>     >     > Duende
>     >     > in
>     >    
>     http://maradns.org/download/2.0/snap/maradns-Q.20110708.1.tar.bz2 or
>     >     > another recent snapshot, since I did apply Yarin's '--pid'
>     code to
>     >     > Duende already.
>     >     >
>     >     > - Sam
>     >     >
>     >     > 2011/7/13 Nicholas Bamber <[email protected]
>     <mailto:[email protected]>
>     >     <mailto:[email protected] <mailto:[email protected]>>
>     >     > <mailto:[email protected]
>     <mailto:[email protected]> <mailto:[email protected]
>     <mailto:[email protected]>>>>
>     >     >
>     >     >     Sam,
>     >     >            I am offering up two patches. One is a spelling
>     patch. The
>     >     >     other is all
>     >     >     the extra argument stuff and related fixes.
>     >     >
>     >     >            With regards to Debian bureaucracy I have just been
>     >     made a Debian
>     >     >     developer so there is one less layer thereof.
>     >     >
>     >     >     --
>     >     >     Nicholas Bamber | http://www.periapt.co.uk/
>     >     >     PGP key 3BFFE73C from pgp.mit.edu <http://pgp.mit.edu>
>     <http://pgp.mit.edu>
>     >     <http://pgp.mit.edu>
>     >     >
>     >     >
>     >
>     >
>     >     --
>     >     Nicholas Bamber | http://www.periapt.co.uk/
>     >     PGP key 3BFFE73C from pgp.mit.edu <http://pgp.mit.edu>
>     <http://pgp.mit.edu>
>     >
>     >
> 
> 
>     --
>     Nicholas Bamber | http://www.periapt.co.uk/
>     PGP key 3BFFE73C from pgp.mit.edu <http://pgp.mit.edu>
> 
> 


-- 
Nicholas Bamber | http://www.periapt.co.uk/
PGP key 3BFFE73C from pgp.mit.edu