Re: PowerDNS Authoritative Server 3.3 Release Candidate 1 available

On Fri, Jun 07, 2013 at 11:54:48PM +0300, Aki Tuomi wrote:
> On Sat, Jun 08, 2013 at 12:53:21AM +1030, [email protected] wrote:
> > On 2013-05-28 17:45, Peter van Dijk wrote:
> > >-----BEGIN PGP SIGNED MESSAGE-----
> > >Hash: SHA1
> > >
> > >Hi everybody,
> > >
> > >Release Candidate 1 of the PowerDNS Authoritative Server 3.3 is
> > >available from:
> > >
> > >http://powerdnssec.org/downloads/pdns-3.3-rc1.tar.gz
> > <snip>
> > >
> > >You are cordially invited to (carefully) test this Release
> > >Candidate for
> > >correct behaviour.
> > 
> > This is failing to compile on OSX 10.7. :(
> > 
> > **************************************************
> >   <snip>
> >   CXXLD  pdns_control
> >   CXXLD  pdnssec
> >   CXXLD  dnsreplay
> >   CXX    version.o
> > version.cc:29:25: error: expected ')'
> >   return string("clang "__clang__version);
> >                         ^
> > version.cc:29:16: note: to match this '('
> >   return string("clang "__clang__version);
> >                ^
> > 1 error generated.
> > make[4]: *** [version.o] Error 1
> > make[4]: *** Waiting for unfinished jobs....
> > make[3]: *** [all-recursive] Error 1
> > make[2]: *** [all] Error 2
> > make[1]: *** [all-recursive] Error 1
> > make: *** [all] Error 2
> > $
> > **************************************************
> > 
> > Any idea what might cause that?
> > 
> > + Justin
> > 
> 
> Hi!
> 
> Can you try patching the code with 
> 
> https://github.com/PowerDNS/pdns/pull/854
> 
> and see if this fixes your problem? 
> 
> Aki Tuomi

Actually there are several CLANG problems at least on linux, so try this
small patch:

diff --git a/pdns/version.cc b/pdns/version.cc
index 577d4bb..caac17f 100644
--- a/pdns/version.cc
+++ b/pdns/version.cc
@@ -25,8 +25,12 @@ static string productName("");
 string compilerVersion()
 {
 #if defined(__clang__)
+#ifdef CLANG_VERSION_STRING
   // clang defines __GNUC__ as well, so put it first.
+  return string("clang " CLANG_VERSION_STRING);
+#else
   return string("clang "__clang__version);
+#endif
 #elif defined(__GNUC__)
   return string("gcc "__VERSION__);
 #elif defined(_MSC_VER)

Hope this fixes your issue.

_______________________________________________
Pdns-dev mailing list
[email protected]
http://mailman.powerdns.com/mailman/listinfo/pdns-dev

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAlGyTsMACgkQahHbMDrZuj6fbACfbSosYX8RPTC9HTRwR6aJia+Q
nnMAmQGxCfNuCiFEmYNIOTWnex0pHf3o
=fkYl
-----END PGP SIGNATURE-----