Re: Etherboot 5.5

On Fri, 20 May 2005, Michael Brown wrote:
> > In file included from arch/i386/core/hooks.c:1:
> > arch/i386/include/registers.h:19: warning: declaration does not declare 
> > anything
> > arch/i386/include/registers.h:87: warning: declaration does not declare 
> > anything
> > arch/i386/include/registers.h:88: warning: declaration does not declare 
> > anything
> > In file included from include/etherboot.h:157,
> >                   from include/buffer.h:4,
> >                   from include/dev.h:6,
> >                   from include/main.h:4,
> >                   from arch/i386/core/hooks.c:2:
> > include/tftp.h:88: warning: "struct buffer" declared inside parameter list
> > include/tftp.h:88: warning: its scope is only this definition or 
> > declaration, which is probably not what you want
> > arch/i386/core/hooks.c: In function `arch_main':
> > arch/i386/core/hooks.c:20: error: structure has no member named `eax'
> > arch/i386/core/hooks.c:23: error: structure has no member named `eax'
> > make: *** [bin/hooks.o] Error 1
> 
> The "struct buffer" issue is due to a tweak I had to make today to get
> doxygen to work; I've fixed this now.  The "does not declare anything"
> is because gcc 3.4.3 apparently doesn't like having unnamed structs.  I
> though that this was supported; I'll have to check.  We don't make
> significant use of the structures in registers.h, so changing them to
> named structs will not be too hard, though it will make the code a
> little less clean.

I've switch registers.h over to using named struct elements, and updated
the code that depends on the structures in registers.h.  I'm not sure if
unnamed struct elements are used elsewhere, and gcc 3.2.2 doesn't seem to 
have a problem with them anyway, so please let me know if you still can't 
compile the code.

Getting the code to the stage that everyone who wants to work on it can at 
least compile it is a high priority for me.

Michael



-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7412&alloc_id=16344&op=click