Bug in etherboot/src/core/nic.c

I just found a bug in the file "etherboot/src/core/nic.c".
This only takes places if you compile for BOOTP ("NO_DHCP_SUPPORT" is
defined).
Without my change, the compiler will find an undefined symbol ("timeout").
Here is the diff file for etherboot 5.4.0 (i just looked at the latest nic.c
and it still contains the bug):


*** nic.c.buggy	2005-03-09 07:52:26.000000000 +0100
--- nic.c	2005-05-30 15:43:27.000000000 +0200
***************
*** 967,973 ****
  		remaining_time = rfc2131_sleep_interval(BOOTP_TIMEOUT,
retry++);
  		stop_time = currticks() + remaining_time;
  #ifdef	NO_DHCP_SUPPORT
! 		if (await_reply(await_bootp, 0, NULL, timeout))
  			return(1);
  #else
  		while ( remaining_time > 0 ) {
--- 967,973 ----
  		remaining_time = rfc2131_sleep_interval(BOOTP_TIMEOUT,
retry++);
  		stop_time = currticks() + remaining_time;
  #ifdef	NO_DHCP_SUPPORT
! 		if (await_reply(await_bootp, 0, NULL, remaining_time))
  			return(1);
  #else
  		while ( remaining_time > 0 ) { 


Regards,
Helge Wagner

For limitations on the use and distribution of this message, please visit www.sbs.com/emaildisclaimer.


-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005