Need patch submission guidance [was: New Myricom 10Gb...]
Glenn Brown <[email protected]> Fri, 03 Mar 2006 08:41:36 -0800
| Newsgroups | gmane.network.etherboot.devel |
|---|---|
| Message-ID | <[email protected]> |
> Glad to hear it is resolved... so should we be expecting a patch for a
> new driver soon? ;-)
Yes, though I need some guidance for our somewhat unusual driver.
To ensure our Etherboot driver is easily maintained, I made it a patched
version of our Linux driver, hiding most of the Linux/Etherboot
differences by adding Linux shim code at the start of our
drivers/net/myri10ge.c file. This allows most patches to our Linux
driver to cleanly apply directly to the Etherboot driver, trivializing
code maintenance.
However, this led to two changes with effects outside our driver:
(1) I had to put 3 small header files in a new src/drivers/net/myri
directory for this diff/patch tracking to work.
(2) I had to patch src/core/relocate.c to ensure virt_offset is a
multipe of 4K.
The latter (2) merits some explanation: every other OS we have ever
supported (Linux, FreeBSD, MacOS X, Irix, SunOS, Solaris, VxWorks, AIX,
Windows NT+) have virt/phys/bus addrs with the bottom 12 bits the same.
This makes bus pointer alignment simple in virt space, and is
essential for this "Linux shim" approach to work cleanly, in light of
the PCI Express requirement that DMAs not cross 4KB boundaries.
So, are (1) and (2) likely to be acceptable to the Etherboot maintainers?
--Glenn
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642