Patch review proces WAS: Patch to align virt and phys spaces on i386
"Timothy Legge" <[email protected]> Thu, 9 Mar 2006 09:06:50 -0400
| Newsgroups | gmane.network.etherboot.devel |
|---|---|
| Message-ID | <[email protected]> |
> -----Original Message----- > From: [email protected] > [mailto:[email protected]] On > Behalf Of Glenn Brown > I'm all for pre-commit reviews, as it's done wonders for our > SW development. At work, we now use this and other parts of > the FreeBSD approach, and it works great. Hi I am certainly fine with this approach. Is there any guidance on how this process will work? Some questions I have are: 1) Can we commit to branches of the cvs to work on code we would like to have in source control prior to submitting it? 2) How will the patches get approved? Should it require comment from a few developers? Which ones? 3) Should we also attach the patches to Sourceforge to better track whether they have been applied? 4) Should a third patches mailing list be created? From what I understand, patch management is handled differently by many projects. Some require the user to resubmit the patch until it is accepted or rejected (lost in email). Others provide voting on a patch or feature. I assume that lack of comment is not implied approval. Does someone need to pick up the "trivial" patches that are occasionally submitted and submit thim in accordance with the patch process? I know that some of this will work itself out as time goes by but its probably a good idea to get everyone on the same page. Regards Tim ********************************************************************** This E-mail message (including attachments, if any) is intended for the use of the individual or entity to which it is addressed and may contain information that is privileged, proprietary, confidential and exempt from disclosure. If you are not the intended recipient, you are notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender and erase this E-mail message immediately. Le present message electronique (y compris les pieces qui y sont annexees, le cas echeant) s'addresse au destinataire indique et peut contenir des renseignements de caractere prive ou confidentiel. Si vous n'etes pas le destinataire de ce document, nous vous signalons qu'il est strictement interdit de le diffuser, de le distribuer ou de le reproduire. Si ce message vous a ete transmis par erreur, veuillez en informer l'expediteur et le supprimer immediatement. ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642