Re: [Etherboot-developers] Comboot - Local Boot Support

On Tue, Sep 23, 2008 at 3:34 PM, Michael Brown <[email protected]> wrote:
> On Monday 22 September 2008 21:54:38 Daniel Verkamp wrote:
>> PS: This patch is also ready for review for mainline; CCing to
>> etherboot-developers (there is an equivalent function for PM instead
>> of RM, so I can write that one as well if desired before review).
>
> Thanks for implementing this.  I'm a bit dubious about constructing executable
> code to implement the register loads; it feels as though there ought to be a
> neater way than this.  Maybe have a static buffer in .text16, copy the
> syslinux_rm_regs struct to this buffer, and use
>
>  __asm__ __volatile__ ( REAL_CODE ( "movl %cs:syslinux_rm_eax, %eax\n\t"
>                                                                .... ) );
>
> to load up the register contents and jump?  It should work out smaller than
> the current code, I think.  You can probably optimise this further.
>
> Michael
>

Ok, I will rework the patch in this way; I followed the way SYSLINUX
did it, but I agree that it could be smaller (SYSLINUX's code
generation uses carefully selected x86 string instructions to build
the code without much size overhead).

Thanks,
-- Daniel

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/