Re: [PATCH] compute checksum for roms bigger than a segment

Glauber Costa <[email protected]> Sat, 28 Mar 2009 01:34:36 -0300
Newsgroups gmane.comp.emulators.bochs.devel,gmane.network.etherboot.devel
Message-ID <[email protected]>
On Sat, Mar 28, 2009 at 03:38:34AM +0000, Michael Brown wrote:
> On Saturday 28 March 2009 00:33:25 Glauber Costa wrote:
> > Some option roms (e1000 provided by gpxe project as an example)
> > are bigger than a segment. The current algorithm to compute the
> > checksum fails in such case. To proper compute the checksum, this
> > patch deals with the possibility of the rom's size crossing a
> > segment border.
> 
> We'll need to address this within gPXE as well.  Our routine for recalculating 
> our ROM checksum assumes that we fit within a single segment.  :(
> 
> Damn these Linux-ported drivers and their excessive code size!
I guess nobody in the linux world have any worries of making things fitting a segment.
Also, I guess nobody would discard patches to make things smaller ;-)

I hope this one is acceptable for bochs in this current form. Let me know
of any concerns you guys have


------------------------------------------------------------------------------