Re: [Etherboot-developers] [PATCH] [myri10ge] new native gPXE driver.

Stefan Hajnoczi <[email protected]> Tue, 5 Jan 2010 21:06:20 +0000

Newsgroups	gmane.network.etherboot.gpxe,gmane.network.etherboot.devel
Message-ID	<[email protected]>

Looks good.  It's nice to see high-end hardware that can be driven in
a clean and simple way.

My only suggestion is that myri10ge_net_close() should not error
outstanding TX.  The net device core code already does this in
net/netdevice.c:netdev_tx_flush().  This function is called right
after the driver's close() returns in net/netdevice.c:netdev_close().

Stefan