Re: [Etherboot-developers] [PATCH] [tftp] Kick off TFTP RRQ from a process to avoid losing first packet
Stefan Hajnoczi <[email protected]> Thu, 14 Jan 2010 09:39:03 +0000
| Newsgroups | gmane.network.etherboot.gpxe,gmane.network.etherboot.devel |
|---|---|
| Message-ID | <[email protected]> |
--0016364593205d4af1047d1ca820 Content-Type: text/plain; charset=ISO-8859-1 Does this patch fix the issue? It should be equivalent to adding a new process. There is still an issue because UDP deliver_iob() does not fail when the packet is dropped due to an ARP cache miss. This means TFTP cannot determine whether a packet it sent was handed to the network device. I haven't audited other UDP user code but it is possible we could change UDP so that users know when packets are hitting the wire versus waiting for ARP. Stefan --0016364593205d4af1047d1ca820 Content-Type: text/x-patch; charset=US-ASCII; name="retry.patch" Content-Disposition: attachment; filename="retry.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g4fch9nq0 RnJvbSBmNWNkMDBiMjFiMmFiYTQxMmM4ZmMxYjkyYmFlN2QzMzEyZWVlOGZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gSGFqbm9jemkgPHN0ZWZhbmhhQGdtYWlsLmNvbT4K RGF0ZTogV2VkLCAxMyBKYW4gMjAxMCAxNzo1Nzo0MSArMDAwMApTdWJqZWN0OiBbdGZ0cF0gUmVt b3ZlIHVubmVjZXNzYXJ5IGRlbGF5IHdoZW4gb3BlbmluZyBhIGNvbm5lY3Rpb24KClRoZSByZXRy eSB0aW1lciBpcyB1c2VkIHRvIHJldHJhbnNtaXQgVEZUUCBwYWNrZXRzIGxvc3Qgb24gdGhlIG5l dHdvcmssCmFuZCB0byBzdGFydCBhIG5ldyBjb25uZWN0aW9uLiAgVGhlcmUgaXMgYW4gdW5uZWNl c3NhcnkgZGVsYXkgd2hpbGUKd2FpdGluZyBmb3IgbmFtZSByZXNvbHV0aW9uIGJlY2F1c2UgdGhl IHRpbWVyIHBlcmlvZCBpcyBmaXhlZCBhbmQgY2Fubm90CmJlIHNob3J0ZW5lZCB3aGVuIG5hbWUg cmVzb2x1dGlvbiBjb21wbGV0ZXMuICBUaGlzIHBhdGNoIGtlZXBzIHRoZSB0aW1lcgpwZXJpb2Qg YXQgemVybyB3aGlsZSBuYW1lIHJlc29sdXRpb24gdGFrZXMgcGxhY2Ugc28gdGhhdCBubyB0aW1l IGlzIGxvc3QKb25jZSBiZWZvcmUgc2VuZGluZyB0aGUgZmlyc3QgcGFja2V0LgoKUmVwb3J0ZWQt Ynk6IFRob21hcyBIb3JzdGVuIDx0aG9tYXNAaG9yc3Rlbi5jb20+ClNpZ25lZC1vZmYtYnk6IFN0 ZWZhbiBIYWpub2N6aSA8c3RlZmFuaGFAZ21haWwuY29tPgotLS0KIHNyYy9uZXQvdWRwL3RmdHAu YyB8ICAgMTEgKysrKysrKysrLS0KIDEgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAy IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9uZXQvdWRwL3RmdHAuYyBiL3NyYy9uZXQv dWRwL3RmdHAuYwppbmRleCAxZGM4ZDNiLi43MGYzMTMzIDEwMDY0NAotLS0gYS9zcmMvbmV0L3Vk cC90ZnRwLmMKKysrIGIvc3JjL25ldC91ZHAvdGZ0cC5jCkBAIC00NDUsOSArNDQ1LDE2IEBAIHN0 YXRpYyBpbnQgdGZ0cF9zZW5kX2FjayAoIHN0cnVjdCB0ZnRwX3JlcXVlc3QgKnRmdHAgKSB7CiAg Ki8KIHN0YXRpYyBpbnQgdGZ0cF9zZW5kX3BhY2tldCAoIHN0cnVjdCB0ZnRwX3JlcXVlc3QgKnRm dHAgKSB7CiAKLSAgICAgICAvKiBVcGRhdGUgcmV0cmFuc21pc3Npb24gdGltZXIgKi8KKyAgICAg ICAvKiBVcGRhdGUgcmV0cmFuc21pc3Npb24gdGltZXIuICBXaGlsZSBuYW1lIHJlc29sdXRpb24g dGFrZXMgcGxhY2UgdGhlCisgICAgICAgICogd2luZG93IGlzIHplcm8uICBBdm9pZCB1bm5lY2Vz c2FyeSBkZWxheSBhZnRlciBuYW1lIHJlc29sdXRpb24KKyAgICAgICAgKiBjb21wbGV0ZXMgYnkg cmV0cnlpbmcgaW1tZWRpYXRlbHkuCisgICAgICAgICovCiAgICAgICAgc3RvcF90aW1lciAoICZ0 ZnRwLT50aW1lciApOwotICAgICAgIHN0YXJ0X3RpbWVyICggJnRmdHAtPnRpbWVyICk7CisgICAg ICAgaWYgKCB4ZmVyX3dpbmRvdyAoICZ0ZnRwLT5zb2NrZXQgKSApIHsKKyAgICAgICAgICAgICAg IHN0YXJ0X3RpbWVyICggJnRmdHAtPnRpbWVyICk7CisgICAgICAgfSBlbHNlIHsKKyAgICAgICAg ICAgICAgIHN0YXJ0X3RpbWVyX25vZGVsYXkgKCAmdGZ0cC0+dGltZXIgKTsKKyAgICAgICB9CiAK ICAgICAgICAvKiBTZW5kIFJSUSBvciBBQ0sgYXMgYXBwcm9wcmlhdGUgKi8KICAgICAgICBpZiAo ICEgdGZ0cC0+cGVlci5zdF9mYW1pbHkgKSB7Ci0tIAoxLjYuNQo= --0016364593205d4af1047d1ca820 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ gPXE mailing list [email protected] http://etherboot.org/mailman/listinfo/gpxe --0016364593205d4af1047d1ca820--