Re: [PATCH] [pciextra] Restore the PCI COMMAND register after writing to the BARs

Am 29.01.2010 15:01, schrieb ext Marty Connor:
>
> On 1/29/10 8:39 AM, Marty Connor wrote:
> > On 1/22/10 10:25 AM, Bernhard Kohl wrote:
> >> By the way, I saw that my patch was already applied on the master
> >> branch. There is some disordering of the comment lines. The line /* 
> Find
> >> the significant bits */ must go 2 lines lower.
> >> Thank You
> >> Bernhard
> >
> > Hi Bernhard,
> >
> > I rewrote the pci_bar_size function for clarity and to make clear that
> > we (gPXE developers) are not convinced that the saving of the
> > PCI_COMMAND word is needed.
> >
> > Our larger concern is that we are masking a KVM PCI bug here, and we
> > would prefer not to add this work-around to our code if we can avoid 
> it.
> >  As far as I can tell, the saving and restoring of that word is a NOOP.
> >
> > Please test the attached patch and let us know if it works.
> >
> > Thanks for your help with this,
> >
> > / Marty /
>
> I messed up the first patch.  Please try the attached one instead.
>
> Thanks,
>
> / Marty /
>
>
Hi Marty,

your rewritten patch works well for me.
I'll try to do the additional tests as requested by Stefan during the 
next days.

And congratulations for the gPXE-1.0.0 release!

Bernhard