Re: [PATCH] [dhcp] Use random transaction ID to associate messages
Yaniv Kaul <[email protected]> Thu, 15 Sep 2011 10:13:52 -0400 (EDT)
| Newsgroups | gmane.comp.emulators.kvm.devel,gmane.network.etherboot.devel |
|---|---|
| Message-ID | <1441335413.692660.1316096032278.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> |
----- Original Message ----- > On Thu, 15 Sep 2011 21:00:38 +0800, Amos Kong <[email protected]> > wrote: > > > + netdev->xid = random(); > > This will not work for reboots. The decision that the hardware address > is > choosen was not accidental. Not sure if some DHCP server will count on > the > ID. (RFC 2131 "Retain DHCP client configuration across server reboots, > and, > whenever possible, a DHCP client should be assigned the same > configuration > parameters despite restarts of the DHCP mechanism"). If not so I am > fine > with the patch. > > Hagen But a DHCP client should be identified by its MAC, not the xid. Y. > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html