Re: gPXE scripts and boot module order

On Thu, Aug 13, 2009 at 5:22 PM, Michael Brown<[email protected]> wrote:
> On Thursday 13 August 2009 16:47:42 Stefan Hajnoczi wrote:
>> I will write a patch for this; it could solve the modules memory map
>> problem we currently have with multiboot.  Solaris expects multiboot
>> modules to be within the usable memory map regions whereas they are
>> currently excluded.
>
> Isn't that issue fixed by moving the call to multiboot_build_memory_map() to
> after the call to shutdown()?
>
> (I seem to remember a patch relating to this recently, though I don't think
> anyone has put it into the staging tree yet.)
Yes, I fixed it by moving the call.  Setting up multiboot modules
using prep_segment() seems cleaner than running code after shutdown().
 Code executing in special environments like relocate() or after
shutdown() requires extra care since there are functions you cannot
use under those conditions, so I'd like to avoid adding more.

Would you prefer moving the call to after shutdown()?

Stefan

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july