[PATCH] Dissect Message Ack responses

Jelmer Vernooij <[email protected]>
Newsgroups gmane.network.ethereal.devel
Organization Samba Team
Message-ID <[email protected]>
Hi,

The attached patch adds proper dissection for the Ack message in OSCAR's
Messaging SNAC family.

Cheers,

Jelmer

-- 
Jelmer Vernooij <[email protected]> - http://samba.org/~jelmer/

_______________________________________________
Ethereal-dev mailing list
[email protected]
http://www.ethereal.com/mailman/listinfo/ethereal-dev
ethereal-aim-msg-ack.diff (text/x-patch, 1.2 KB)
Index: epan/dissectors/packet-aim-messaging.c
===================================================================
--- epan/dissectors/packet-aim-messaging.c	(revision 18143)
+++ epan/dissectors/packet-aim-messaging.c	(working copy)
@@ -478,6 +478,20 @@
 	return offset;
 }
 
+static int dissect_aim_msg_ack(tvbuff_t *tvb, packet_info *pinfo, proto_tree *msg_tree)
+{
+	int offset = 0;
+
+	proto_tree_add_item(msg_tree,hf_aim_icbm_cookie, tvb, offset, 8, FALSE); offset+=8;
+
+	proto_tree_add_item(msg_tree, hf_aim_message_channel_id, tvb, offset, 2,
+						FALSE); offset += 2;
+
+	offset = dissect_aim_buddyname(tvb, pinfo, offset, msg_tree);
+	
+	return offset;
+}
+
 static int dissect_aim_msg_clientautoresp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *msg_tree)
 {
 	int offset = 0;
@@ -514,7 +528,7 @@
 	{ 0x0009, "Evil Response", dissect_aim_msg_evil_repl  },
 	{ 0x000a, "Missed Call", NULL },
 	{ 0x000b, "Client Auto Response", dissect_aim_msg_clientautoresp },
-	{ 0x000c, "Acknowledge", NULL },
+	{ 0x000c, "Acknowledge", dissect_aim_msg_ack },
 	{ 0x0014, "Mini Typing Notifications (MTN)", dissect_aim_msg_minityping },
 	{ 0, NULL, NULL }
 };
signature.asc (application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQBEZeTRPa9Uoh7vUnYRAklIAJ9DjbTxCiD4aavgRK3ifbYrWZL8DQCfUfEI
S75LPKtkkkyb4fjbo3JAF5I=
=IiH3
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.