Re: [Ethereal-cvs] rev 18183: /trunk/epan/: emem.c

[email protected] wrote:
> User: lroland
> Date: 2006/05/17 07:25 PM
>
> Log:
>  Improve fix for Bug 915 by using GetVersionEx() as it is recommended by Microsoft. Tested on Win98 SE.
>
>   
So what's the difference between:

versinfo.dwOSVersionInfoSize = sizeof(OSVERSIONINFO);

and

*static* OSVERSIONINFO versinfo;

versinfo.dwOSVersionInfoSize = sizeof(versinfo);

?!?


You've removed the handling if GetVersionInfoEx fails, which makes your 
solution:

- "Microsoft recommended"
- fail if the call to GetVersionInfoEx fails

Just because Microsoft gives examples that way doesn't mean that it's 
the right solution :-)

People reported problems that the call the GetVersionInfoEx() failed on 
their machines (on Win98 First Edition, for whatever reason), so I got 
the strong feeling your solution is even worse than mine ;-)

Regards, ULFL