missing voip calls setupAck label + patch?
Cvetan Ivanov <[email protected]>
| Newsgroups | gmane.network.ethereal.devel |
|---|---|
| Message-ID | <[email protected]> |
Hello, Yesterday I got a h323 trace of a call with overlap signaling. This is somehow unusual, and thing go ugly when it happens and your system is not ready for it. What I noticed is that the voip call flow graph does not have a label for the setupAck packet. I traced this to the empty frame_label. This could be fixed with the attached patch, but would it not be possible to find more general solution - generate that as default code if no extra code is provided in h225.cnf or something? Besr regards, Cvetan -- Cvetan Ivanov System Administrator SpectrumNet Jsc. +35929657613 Office _______________________________________________ Ethereal-dev mailing list [email protected] http://www.ethereal.com/mailman/listinfo/ethereal-dev
setupack.diff
(text/plain, 814 B)
Index: asn1/h225/h225.cnf
===================================================================
--- asn1/h225/h225.cnf (revision 18189)
+++ asn1/h225/h225.cnf (working copy)
@@ -261,6 +261,12 @@
g_snprintf(h225_pi->frame_label, 50, "%s", val_to_str(h225_pi->cs_type, T_h323_message_body_vals, "<unknown>"));
#.END
#----------------------------------------------------------------------------------------
+#.FN_FTR SetupAcknowledge-UUIE
+ /* Add to packet info */
+ h225_pi->cs_type = H225_SETUP_ACK;
+ g_snprintf(h225_pi->frame_label, 50, "%s", val_to_str(h225_pi->cs_type, T_h323_message_body_vals, "<unknown>"));
+#.END
+#----------------------------------------------------------------------------------------
#.FN_FTR Facility-UUIE
/* Add to packet info */
h225_pi->cs_type = H225_FACILITY;