[PATCH] packet_gsm_a.c, detach request message parsing error.

Hello,

I find a error in dtap_gmm_detach_req() function (packet_gsm_a.c).
"P-TMSI" and "P-TMSI Signature" are not a TV format, but a TLV format.

- Reference: 3GPP TS 24.008 v7.4.0 (2006-06), Mobile radio interface Layer 3
specification,
                  Core network protocols; Stage 3. ch 9.4.5 Detach Request.

http://www.3gpp.org/ftp/Specs/archive/24_series/24.008/24008-740.zip

Best Regards,
Kyoung-Hwan Lee.

Index: epan/dissectors/packet-gsm_a.c
===================================================================
--- epan/dissectors/packet-gsm_a.c      (revision 18189)
+++ epan/dissectors/packet-gsm_a.c      (working copy)
@@ -16436,9 +16436,9 @@

     ELEM_OPT_TV( 0x25 , BSSAP_PDU_TYPE_DTAP, DE_GMM_CAUSE , "" );

-    ELEM_OPT_TV( 0x18 , BSSAP_PDU_TYPE_DTAP, DE_MID , " - P-TMSI" );
+    ELEM_OPT_TLV( 0x18 , BSSAP_PDU_TYPE_DTAP, DE_MID , " - P-TMSI" );

-    ELEM_OPT_TV( 0x19 , BSSAP_PDU_TYPE_DTAP, DE_MID , " - P-TMSI Signature"
);
+    ELEM_OPT_TLV( 0x19 , BSSAP_PDU_TYPE_DTAP, DE_MID , " - P-TMSI
Signature" );

     EXTRANEOUS_DATA_CHECK(curr_len, 0);
}

_______________________________________________
Ethereal-dev mailing list
[email protected]
http://www.ethereal.com/mailman/listinfo/ethereal-dev