Re: bug in packet-bgp.c (Ethereal) and print-bgp.c (tcpdump)
Hannes Gredler <[email protected]> Fri, 06 Oct 2006 08:29:09 +0200
| Newsgroups | gmane.network.ethereal.devel,gmane.network.tcpdump.devel |
|---|---|
| Message-ID | <[email protected]> |
------------------- The Ethereal project is being continued at a new site. Please go to http://www.wireshark.org and subscribe to [email protected]. Don't forget to unsubscribe from this list at http://www.ethereal.com/mailman/listinfo/ethereal-dev ------------------- aaron, i have checked in your fix into HEAD and the 3.9 branch of tcpdump and added you to the hall of shame ;-) aka CREDITS file. tx for your submission. --- also ethereal is depreceated - you may want to submit your patch tothe wireshark developers list [www.wireshark.org] /hannes Aaron Campbell wrote: > The expression (BGP_OSPF_RTYPE_EXT ||BGP_OSPF_RTYPE_NSSA) will always > evaluate to 1. As well, neither of these constants are defined as flag > values, so a bitwise op was probably not intended either.