Re: Subversion still down, emergency measures

Karine Proot <[email protected]> Tue, 01 Jun 2004 19:37:51 +0200
Newsgroups gmane.network.everybuddy.devel
Message-ID <1086111471.3456.19.camel@gelydh>
--=-hv1G44xLibWHMihBQyOS
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Tue, 2004-06-01 at 00:32, Meredydd wrote:
> Hey all,
> 	With subversion still down, and the next alpha so overripe it's 
> starting to smell, it looks like it's time for emergency measures.
> 
> #1)	Going to alternative trees. Anyone with outstanding core patches, 
> please attach them in a reply to this thread. I will commit them to my 
> own personal tree, which will become the official master copy for the 
> moment.
> 
> Maintainers of other trees (ebqt, ebnc, cory's Jabber, Craig's 
> libyahoo2), your copies are, for the time being, the masters. 
> Nonetheless, please do send me patches, cause it looks like we're going 
> to be releasing from my personal tree.
How sad.
Can you please apply Craig's latest patch (see below) ?

> #2)	Let's talk release! What needs to be done:
> 
> 	*	Craig's AIM fixes need to be working.
> 	*	I need to fix MSN
> 
> Does anyone else have something which ought to be on that list?
Yay! Release!
Nothing important for me (I think?), I'll try to add as many
functionnalities as I can (discovering that people don't all have the
same idea about what is the most important...)

> #3)	Anyone whose code will be in the next alpha, *please* reply to this 
> message, if only to say that it's all fine and ready to release. If 
> nothing else, I need to know you guys are still alive...
All fine with Craig's patch. Ah, realizing... Changelog should come
along with it. Which means it is the day I learn how to make a patch. 

Oooh, so easy. Here you are.

Karine


--=-hv1G44xLibWHMihBQyOS
Content-Disposition: attachment; filename=ebnc.patch
Content-Type: text/x-patch; name=ebnc.patch
Content-Transfer-Encoding: 7bit

Index: windows.h
===================================================================
--- windows.h	(revision 357)
+++ windows.h	(working copy)
@@ -77,6 +77,7 @@
   int getType() const;
   void setPrevious(Tab *t);
   void setNext(Tab *t);
+  void setCurrentWin(WINDOW *currentWin);
   void setActivity(int activity);
  private:
   Tab *previous;
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 362)
+++ ChangeLog	(working copy)
@@ -1,3 +1,6 @@
+2004-05-20  Karine Proot <[email protected]>
+	* windows.h, windows.cpp: Craig's patch to fix a bug when closing a tab
+
 2004-05-16  Karine Proot <[email protected]>
 	* ChangeLog: Sweet, emacs recognizes author, e-mail, and filenames when ChangeLog is properly written. I love colors!
 
Index: windows.cpp
===================================================================
--- windows.cpp	(revision 358)
+++ windows.cpp	(working copy)
@@ -246,6 +246,11 @@
   next = t;
 }
 
+void Tab::setCurrentWin(WINDOW *currentWin)
+{
+  this->currentWin = currentWin;
+}
+
 void Tab::setActivity(int activity)
 {
   this->activity = activity;
@@ -416,12 +421,25 @@
 {
   //t2 is the first tab unseen before removal (NULL if all tabs were on screen)
   int i = getIndex(t);
-  wclear(tabWins[i]);
   if (i > -1)
   {
     for (int j=i; j < number-1; j++)
+    {
+      wclear(tabWins[j]);
       tabs[j] = tabs[j+1];
+      if (tabs[j])
+      {
+	tabs[j]->setCurrentWin(tabWins[j]);
+        mvwaddstr(tabWins[j], 0, 0, tabs[j]->getShortName());
+      }
+    }
+    wclear(tabWins[number-1]);
     tabs[number-1] = t2;
+    if (tabs[number-1])
+    {
+      tabs[number-1]->setCurrentWin(tabWins[number-1]);
+      mvwaddstr(tabWins[number-1], 0, 0, tabs[number-1]->getShortName());
+    }
   }
 }
 

--=-hv1G44xLibWHMihBQyOS
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Everybuddy-Dev mailing list
[email protected]
http://lists.spine.cx/listinfo/everybuddy-dev

--=-hv1G44xLibWHMihBQyOS--