Re: A couple of core cleanups

On Sunday 07 March 2004 20:41, A. Craig West wrote:
> Two things for the core. First, to prevent various subversion
> syncronization issues, we need to remove various target files from
> subversion. It doesn't work when I do it to ebqt, so I will leave it
> alone, but the core doesn't mind elimination all .in files, and it
> will make our lives a lot easier... eb-lite$ svn status
> !      core/libltdl/config.h.in
> !      core/libltdl/configure.in
> !      core/libltdl/stamp-h.in
> !      core/stamp-h.in
> !      core/config.h.in
Feel free, blow them away.

> -static char * true_string = "1";
> -static char * false_string = "0";
> +#define TRUE_STRING "1"
> +#define FALSE_STRING "0"
Hmm...I'm still not sure this is a good idea. Why bother assigning 
symbolic names to "1" and "0", when it's pretty darn obvious what they 
mean?

Contrast the following:

>    notify_command[5]=(td->is_html)?(TRUE_STRING):(FALSE_STRING);
...and...
>   notify_command[5]=(td->is_html)?("1"):("0");

Now, to me at least, the second line is actually significantly clearer 
to read.

Meredydd