Re: Core bug, and ebnc bug when handling the core bug

Karine Proot <[email protected]> Sun, 21 Mar 2004 10:46:27 +0100
Newsgroups gmane.network.everybuddy.devel
Message-ID <1079862387.2463.5.camel@gelydh>
On Sun, 2004-03-21 at 09:04, A. Craig West wrote:
> The file ebncurses.cpp needs to have more error checking added, it tends to assume
> that just because an account name appears in a command from the core, that
> account must already exist, so there is no NULL checking for the various
> find() methods while parsing. 

That's true, I did no check at first because I wanted to have ebnc
running as soon as possible... And of course with time I let it that
way. Bad me. Anyway it's a general problem in ebnc, should review all my
code and add checkings everywhere now it's getting near useability.


A question about const method (I'm trying to switch all my getters to
const right now) :
   Tab *getPrevious();
becomes
   Tab *getPrevious() const;

I have elsewhere:
   buddyTab = static_cast<BuddyTab*>(tabs->getFirst()->getPrevious());

but this line fails at linking:
   undefined reference to `Tab::getPrevious()'

   If someone could show me the light...

Karine