IRC patche and a few other things
Cory McWilliams <[email protected]> Thu, 25 Dec 2003 23:28:57 -0500
| Newsgroups | gmane.network.everybuddy.user |
|---|---|
| Message-ID | <[email protected]> |
Hello, I just stumbled onto eb-lite and wanted to say that I'm very excited about it. For a long time I've wanted to make something just like it, so I'm very happy to finally see something out there. Attached are two patches, created by "svn diff" from the root of the trunk branch. core.patch.gz fixes two silly counting errors that struck me as odd. It also makes sure account->blocked is defined in one place, which struck valgrind's memory checker as odd. The IRC patch changes a few things in irc.c that bothered or scared me. Sending a multi-line message previously was an easy way to anger the IRC server (lines after the first are interpreted as raw commands to the server). I replaced the newlines with spaces, but I believe it's more common to cause a message with newlines to be sent as multiple single-line messages. Unfortunately I can't seem to get my head around the eb-lite code enough to make that happen. The way messages are read from the server and parsed seems a bit awkward. The patch tries to make sure every line is read and handled to the end, where before it stopped short in some places, in sometimes causing annoying errors. I might see if It's any better off reading in whole lines before parsing if I get the time. I attempted to pull the /commands out so that the instant messages and messages to group chats are handled in a common way. Hopefully that doesn't introduce any trouble, and now that I look at it, that may even have been a TODO item. Channels can start with & in addition to #, but that's a little picky. I added a /raw command to send unmodified commands to the server. I think that's most of it, for whatever it's worth. I will do whatever I can to help, or I have a few things of my own I intend to work on for eb-lite. I'm 'Unprompted' on AIM and irc.oftc.net. Happy Holidays, Cory McWilliams _______________________________________________ Everybuddy mailing list [email protected] http://lists.spine.cx/listinfo/everybuddy
irc.patch.gz
(application/x-gzip, 3 KB) - not displayed
core.patch.gz
(application/x-gzip, 490 B) - not displayed