Re: BUGS: IRC groupchat

OK, commit it and get people to test. Note that all of the changes 
discussed on the list are in trunk/ for the time being - I need to make 
a few tweaks before I do my next promote (chat log code needs a bullet 
to the head fttb). In fact, if you and Craig could confirm when you've 
commited your changes, I can do my edits this evening, and promote up 
to bleeding.

Meredydd

On Wednesday 11 February 2004 23:43, Cory McWilliams wrote:
> Hi,
>
> I think I am indeed the one to blame for this one.
>
> Oddly, I haven't really been able to reproduce this behavior.  On
> what IRC servers are people noticing this?
>
> Howver, based on what you described, I think I found the culprit. 
> Due to an off-by-one error I made, a null character was being written
> at the end of an ISON message which is sent periodically.  I imagine
> some servers interpreted that as part of the next message, causing it
> to be "lost," which I think could have caused everything you
> describe.
>
> Attached is a patch for the one line, which I coincidentally marked
> as "tricky" at the time...sigh.
>
> Please let me know whether this makes a difference.
>
> Sorry,
> Cory
>
> On Wed, 2004-02-11 at 16:48, Karine Proot wrote:
> > Hello,
> >
> >    A test sequence I ran :
> >
> > * Connecting to an IRC account.
> > * Can't join groupchat (already reported by Meredydd. I have to
> > disconnect and try again until it will accept to join a group chat)
> >
> > * Connecting to an IRC account.
> > * Joined a group chat.
> >     ChanServ talks to me.
> >     I get a "eb_get_filename failed: File exists" on core output
> > * Talked first in the groupchat
> >     !!! first message didn't arrive
> >     following OK
> > * Waited for someone to talk
> >     OK
> > * Talked in the groupchat
> >     !!! first message didn't arrive
> >     following OK
> > -> a few more tests seem to lead to the conclusion that first
> > message never get throught, following ones are OK. This varies a
> > little. * Left the groupchat
> >     !!! nothing happens, I still appear in it (from other client)
> > * Waited for someone to talk
> >     !!! All messages arrive as query message and buddies are added
> > to list accordingly.
> >     At some point, the groupchat reopened and all following
> > messages appeared on it. Noboddy in the groupchat list.
> >
> >
> > _______________________________________________
> > Everybuddy mailing list
> > [email protected]
> > http://lists.spine.cx/listinfo/everybuddy