Re: Alpha-11 blockers

OK, couple of problems with this:

On Friday 20 February 2004 23:37, A. Craig West wrote:
> +#define FORCE_NEW_PLUGINS_DIR
>  #ifndef PLUGINS_DIR
> -# define PLUGINS_DIR "/usr/local/share/eb-lite/plugins"
> +# define OLD_PLUGINS_DIR "/usr/local/share/eb-lite/plugins"
> +# define PLUGINS_DIR "/usr/local/lib/eb-lite"
>  #endif

Shouldn't this be taken from config.h or something? After all, if 
someone has done ./configure --prefix=/usr, you want to be looking 
in /usr/lib/eb-lite, not /usr/local/lib.

> +    eb_put_default(registry, "config/plugin_dir", PLUGINS_DIR);
Ack no no! eb_put_default() only inserts a value into the registry if 
it's not already set to something, so by definition it will do nothing 
inside this if() statement. You want plain vanilla eb_put_value() here.

Meredydd